Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wN8Gh-000bEc-01 for pgsql-hackers@arkaria.postgresql.org; Wed, 13 May 2026 12:00:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wN8Gf-008eJw-2N for pgsql-hackers@arkaria.postgresql.org; Wed, 13 May 2026 12:00:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wN8Gf-008eJn-1N for pgsql-hackers@lists.postgresql.org; Wed, 13 May 2026 12:00:49 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wN8Gd-00000000MWc-0kyb for pgsql-hackers@postgresql.org; Wed, 13 May 2026 12:00:48 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so71363625e9.0 for ; Wed, 13 May 2026 05:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1778673641; x=1779278441; darn=postgresql.org; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=bFfniPVJezfmAnp57ThF55RUNLV480hsppdbpt7+g6g=; b=WFsOePWlKXlrQi2kScK6bvvhueAKz3CBeYXUGqXiG+xo5LmUBkGSl/FJM3Qj/b2Htj Cjh8Bfqvpd20HXro38p4agHRg46gWEgzgw+A/w2mgnLZDXrnGqMuBJoQpHRM1zBBSJ9j J+24jfcRYqXPzS3qboyrZ+NX/TXBrqUbfjnxcYof/U6YimIqvpbIJhQhx9Kf6Kdyj0aA sFAAY2+F37/WTWP5JR/OL+LcBab/5IPRQ+LWaVBIvTd84Sv5pGiocA3fZd4Cnji6uWij eqHIX1isVTGiK7Xf+k7zvAepGGFt4kDkw0DMcnj0cCvD8CIvzlDWYwDoGbUFugNlyXbE suzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778673641; x=1779278441; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bFfniPVJezfmAnp57ThF55RUNLV480hsppdbpt7+g6g=; b=R6J6b9pSlFBkcVu12CNLaXw1hr7M/DtfqwJOdp/O3JyCWjV/TQ/SqSnhpkpcYGauV4 DAp7Fg9GIUTADPUOi8UlnbxO9VtD16C4OglTDNhHsem9duJerczWBfEfvpJTs2MZoDaw zEMHcqOysB5YJ0wDB7PDSYVBA4vrttKda2EaRuIkSWwXIY0lZ6eQp6Qf8bLCGD2LVQHB Sar1FWD+BP7/tyA92csZHMhmztI1khcgbngnpFqSnAy82ADJhB7AD/V/4kmd1F5i1Vij EYRdk6YycDOQYKPPY6PZLVN28OKdWJgRkvdaJFPPJQbQnUsKUwu9mKXrYe4yW6+1XIvr 9Qcw== X-Forwarded-Encrypted: i=1; AFNElJ8K2pWfuvZc2yxq2r2lBwzZpsubSbfnI+wisGeEA49E06zX5b3aBiI/+3rebdNT4+FWwLpYSs6ureRcZwKE@postgresql.org X-Gm-Message-State: AOJu0Yyp3oy1kwz4YtYteO9jg0asIinoLAy8NM55HB3P7X6nzVwy5Mse KsHMISVFrv46uCb9GiTHxqnBbblpuW2yFEIQqfHZs2eMANpCkCtE2gzhO5X18delolE= X-Gm-Gg: Acq92OGwctYF2pPJVAeZ8TeeNKuuuJe1bqZwtIR04H/NUGOjQOo+6CRY+ImWjU+rc+J DGAzhScdwZM5OwVC+8plvLGnc0QbSZfl3xh3RKt2XvLokNASm4/KWBtFXTf6A6/Zr7RpSyxnb0h 670FUuPn+UoAadXGI4d7cLbw4H5UjgxpHvwrQ+7TgrvIi+k1BoruxZ1C5QfYnYBU/hgqphgw75W YqTvAWJkEHPpLqo9nywChz/ojFQwxPvegHNCgq3Is9yRYh/OA3+zwEQGHZGvx2zABO/6OxJ6Ad0 fdFVJVwb+f9Z6eL48XJQCEZ6SNmaTt8XFlgf0ddcUZ9Azw46rshN2Vs9Pg2VGvP3W49sYf1jdQq 7C5WCnnpBW3w6oy45gKEjlFvKek/rWlseSfGSPeNN1YIb6dnvL9wfaOfOipRieCjTDFhPxpkhnt FmdZ2MRSEUMM075WphfkQZQXaANbGucF2OHlABy1yIFM0iLSw= X-Received: by 2002:a05:600c:3e8f:b0:48a:f18:ece4 with SMTP id 5b1f17b1804b1-48fc9a4948amr45804045e9.24.1778673641071; Wed, 13 May 2026 05:00:41 -0700 (PDT) Received: from localhost (109-81-168-142.rct.o2.cz. [109.81.168.142]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fc8d1f3d8sm62783485e9.5.2026.05.13.05.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 05:00:39 -0700 (PDT) From: Antonin Houska To: Chao Li cc: alvherre@kurilemu.de, Kirill Reshke , PostgreSQL-development Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes In-reply-to: <69CA7636-0359-42B6-B971-16A036698187@gmail.com> References: <70401.1778604528@localhost> <69CA7636-0359-42B6-B971-16A036698187@gmail.com> Comments: In-reply-to Chao Li message dated "Wed, 13 May 2026 16:35:30 +0800." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <134575.1778673638.1@localhost> Date: Wed, 13 May 2026 14:00:38 +0200 Message-ID: <134576.1778673638@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Chao Li wrote: > I am not sure whether we should change the behavior in PG19. Alvaro may have > a better idea about that. But I agree that we can at least clarify the code > comment and documentation. The attached patch attempts to do that. I meant just a comment that reminds developers that something needs to be fixed, rather than defending the inconsistent behavior. -- Antonin Houska Web: https://www.cybertec-postgresql.com