Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNFs8-0007h2-Jk for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Feb 2022 15:17:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nNFs7-0001Pi-1M for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Feb 2022 15:17:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNFs6-0001PZ-P6 for pgsql-hackers@lists.postgresql.org; Thu, 24 Feb 2022 15:17:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNFs3-0000ou-UX for pgsql-hackers@postgresql.org; Thu, 24 Feb 2022 15:17:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21OFHS911346757; Thu, 24 Feb 2022 10:17:28 -0500 From: Tom Lane To: Andres Freund cc: Peter Eisentraut , pgsql-hackers@postgresql.org Subject: Re: convert libpq uri-regress tests to tap test In-reply-to: <20220224144311.4rcax7tslk7jum3f@alap3.anarazel.de> References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de> <1261838.1645657117@sss.pgh.pa.us> <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com> <1276236.1645667561@sss.pgh.pa.us> <20220224144311.4rcax7tslk7jum3f@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 24 Feb 2022 06:43:11 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1346755.1645715848.1@sss.pgh.pa.us> Date: Thu, 24 Feb 2022 10:17:28 -0500 Message-ID: <1346756.1645715848@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-02-24 13:31:40 +0100, Peter Eisentraut wrote: >> I think the TAP scripts should be in src/interfaces/libpq/t/, as usual. The >> supporting code snippets could live in some other directory under >> src/interfaces/libpq/, which might be called "test" or something else, not >> that important. > Why not in t/? We can't easily build the test programs in libpq/ itself, but > libpq/t should be fairly doable. I think that having t/ directories contain only Perl test scripts is a good convention that we should stick to. Peter's proposal of a separate test/ subdirectory for C test scaffolding is probably fine. regards, tom lane