Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jZJnj-0000RB-3F
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 May 2020 19:45:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jZJnh-0003TC-Vk
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 May 2020 19:45:49 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jZJnh-0003R7-OU
	for pgsql-hackers@lists.postgresql.org; Thu, 14 May 2020 19:45:49 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jZJnf-0002gR-LG
	for pgsql-hackers@postgresql.org; Thu, 14 May 2020 19:45:49 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 04EJjQtw013488;
	Thu, 14 May 2020 15:45:26 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
        "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: SLRU statistics
In-reply-to: 
 <CA+TgmoZGszNmRrdR_i3emu7MhiEbH3hos0cq4U4fTs-Z+6PUzw@mail.gmail.com>
References: <20200229205518.xrxo535zgd7cl6no@development>
 <20200327004111.md4suoi6u5suv2qe@development>
 <20200328002630.2nz5y3dvymqnvxtv@development>
 <20200402004136.wodwftan45mcwggm@development>
 <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
 <20200430181901.24tlriahmafi4sfn@development>
 <0e1c8904-13be-ab70-0096-54f0b30e43ba@oss.nttdata.com>
 <20200502000818.nn4kpewiput42bnb@development>
 <49b8ad17-f6d9-a086-a952-ff1fec3ac1b3@oss.nttdata.com>
 <20200502105500.hwhba3d6s3hlrqf6@development>
 <20200502165905.brfxv6dk5vjdbgti@development>
 <976bbb73-a112-de3c-c488-b34b64609793@oss.nttdata.com>
 <fd082235-c8dc-3d99-3703-1ba183dc252e@oss.nttdata.com>
 <CA+TgmoZGszNmRrdR_i3emu7MhiEbH3hos0cq4U4fTs-Z+6PUzw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Thu, 14 May 2020 14:52:06 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13486.1589485526.1@sss.pgh.pa.us>
Date: Thu, 14 May 2020 15:45:26 -0400
Message-ID: <13487.1589485526@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> I'm confused by why SLRU statistics are reported by messages sent to
> the stats collector rather than by just directly updating shared
> memory.

It would be better to consider that as an aspect of the WIP stats
collector redesign, rather than inventing a bespoke mechanism for
SLRU stats that's outside the stats collector (and, no doubt,
would have its own set of bugs).  We don't need to invent even more
pathways for this sort of data.

			regards, tom lane