Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcnbR-0005Yb-2z for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Aug 2016 05:53:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bcnbP-0007TR-VT for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Aug 2016 05:53:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bcnbO-0007TI-4D for pgsql-hackers@postgresql.org; Thu, 25 Aug 2016 05:53:22 +0000 Received: from nm7-vm8.bullet.mail.sg3.yahoo.com ([106.10.148.183]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bcnbJ-00007G-NS for pgsql-hackers@postgresql.org; Thu, 25 Aug 2016 05:53:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.in; s=s2048; t=1472104391; bh=OHy9YNdCdyGLRy4Z5m6LlQodPVrVJrdzkmvKuVA7/G0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=m9FqoWYF//Y0hgzDzbJ5EpGgJ/cetQCFRDvqwvQzYZdsQGtTZ0vciKVG3CE46kSNB6BeelCsu02La9KUF3+CcSG/ro6aJXZTGxKDeztA48j/0xZqZr7O4ZA2vT/8hLEt9tAHz8SXiMlhxMqybH0AuWmMQJEa4nNYjLbUK8QP9Bgjr6kQRVF8gqXwWCubIYjQ2qosDRIEVQHAW7O5z4l5Y61885c0DqLc1/HacysGZNZM8giAJONzP1n59teV8twRlc+lPt/XaSlDuXm+irfAED67BW97XSlYxo+vCKYwpexuIp1hntHaHrZs630AIVD8Dtio5jI3yVIrwUn/V8+BDw== Received: from [106.10.166.120] by nm7.bullet.mail.sg3.yahoo.com with NNFMP; 25 Aug 2016 05:53:11 -0000 Received: from [106.10.150.23] by tm9.bullet.mail.sg3.yahoo.com with NNFMP; 25 Aug 2016 05:53:11 -0000 Received: from [127.0.0.1] by omp1024.mail.sg3.yahoo.com with NNFMP; 25 Aug 2016 05:53:11 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 352133.17802.bm@omp1024.mail.sg3.yahoo.com X-YMail-OSG: 4LYEXLEVM1nBwf6j22OJvN_QG3ziJO01a26QPkQEg.iT..ST6I.RARBpXa4Ivla YqLc2LPGgSwAYYIm38ZG1nYDtIoOjvFt5Mw04lpzJUta.codJwDWWEM6LdQ7yy88jGpD3joKFkEj Ps.nM3vH066YxcZG0_GXj3iTtcixuZQ4glENT3FfEY2okw0tPMolTwULt.b1EFIUrz.kjDW_37Z0 VrKMfDPk5dWpy_0Qgk.ysIR5UoPS2qkv6Q8Nts5kZSacJD9aM1XxKP3qBqwRjDTg4hFfq.xePVM_ 6C2RXAQjbKCe30CELsH0c09DAbd_pSsdR5x6c6qfnxW_WOj_ii_K606BcuhDTc5dcKuO5evPZffY FXKLyYT8QG1WzEvs.EWaVZbyCSXRnDcbzPu5wjxWWKH4XXuZWMx7PhBU98qwEA_QcPlhfg8yXdWc O.dXN1.CZp76yadLAkg5Na8b8CRF61ILlX4uLbE.ZZk9w25LuHOweeTUeroTAwt6KkMq_JDePzjb CU_93.tv_.bShoZqr5w6fKr23cg-- Received: from jws10970.mail.sg3.yahoo.com by sendmailws118.mail.sg3.yahoo.com; Thu, 25 Aug 2016 05:53:10 +0000; 1472104390.981 Date: Thu, 25 Aug 2016 05:53:10 +0000 (UTC) From: amul sul Reply-To: amul sul To: Artur Zakirov , Robert Haas Cc: Pavel Stehule , Tom Lane , "David G. Johnston" , Alex Ignatov , Bruce Momjian , PostgreSQL-development Message-ID: <1349968951.17422721.1472104390685.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: <03e76bef-75eb-4d70-40d6-890d42f4dc8e@postgrespro.ru> References: <1873520224.1784572.1465833145330.JavaMail.yahoo.ref@mail.yahoo.com> <31915.1466703655@sss.pgh.pa.us> <32684.1466704957@sss.pgh.pa.us> <734e50cd-c563-4afd-d1c8-80f244b3265e@postgrespro.ru> <1285870380.13225431.1471272994354.JavaMail.yahoo@mail.yahoo.com> <60cc3122-0950-e455-21fe-de89882e285d@postgrespro.ru> <2095510729.14135736.1471444528728.JavaMail.yahoo@mail.yahoo.com> <03e76bef-75eb-4d70-40d6-890d42f4dc8e@postgrespro.ru> Subject: Re: Bug in to_timestamp(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Length: 702 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hi Artur Zakirov, 0001-to-timestamp-format-checking-v3.patch looks pretty reasonable to me, o= ther than following concern: #1. Whitespace @ line # 317. #2. Warning at compilation; formatting.c: In function =E2=80=98do_to_timestamp=E2=80=99: formatting.c:3049:37: warning: =E2=80=98prev_type=E2=80=99 may be used unin= itialized in this function [-Wmaybe-uninitialized] if (prev_type =3D=3D NODE_TYPE_SPACE || prev_type =3D=3D NODE_TYPE_SEPARATO= R) ^ formatting.c:2988:5: note: =E2=80=98prev_type=E2=80=99 was declared here prev_type; ^ You can avoid this by assigning zero (or introduce NODE_TYPE_INVAL ) to pr= ev_type at following line:=20 256 + prev_type; Regards, Amul Sul --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers