public inbox for [email protected]  

help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Corey Huinker <[email protected]>
Cc: jian he <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: [email protected]
Subject: Re: Extended Statistics set/restore/clear functions.
Date: Thu, 04 Dec 2025 21:29:50 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CACJufxGGzkb58BU+YyTa9cBAawhybwk2cPFZ1XupS-8xuAzN9A@mail.gmail.com>
	<[email protected]>
	<CADkLM=czQ0UUyBn3AiHZfJJWRwXH5e2xn056yG0mpuXpW09RSw@mail.gmail.com>
	<CACJufxHVKiVEvCsc11oxOM=0GgjqChFwi-ii4RJuw95ZFB_fHQ@mail.gmail.com>
	<CADkLM=eRop0t==hg0TU3KuDH6DgnUxQ6vZxV9th=6vW1JG36MQ@mail.gmail.com>
	<CACJufxGgEnOzFq0HjmkKBTnEUgToGFC0g0A4wPWoJMzOuoWUhw@mail.gmail.com>
	<CADkLM=crdyK3w7-EDEdDfXHGidxm2ms+bQYNFOZUD4eOLuLXEQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Michael Paquier <[email protected]> writes:
> On Thu, Dec 04, 2025 at 07:37:32PM -0500, Tom Lane wrote:
>> This of course arises because the source code is passing the address
>> of a local ErrorSaveContext variable to that macro.  We don't have
>> any other instances of that coding pattern AFAICS, so I wonder if
>> that was really the most adapted way to do it.

> Thanks for the report.  Right.  There are three instances of that in
> pg_dependencies.c, two in pg_ndistinct.c.  I would not mind doing the
> attached to calm down these warnings, matching with the other areas of
> the code, that simply removes the macro and checks the state value
> directly.

Ah, right, now that you mention it, 56b1e88c8 did this same fix
before.  This way is fine with me.

I didn't review the error message changes closely.  I do wonder if
some of them are can't-happen cases that could just use an elog()
instead of a translatable message.

			regards, tom lane





view thread (91+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Extended Statistics set/restore/clear functions.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox