From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew@dunslane.net>,
        Bruce Momjian <bruce@momjian.us>,
        Michael Paquier <michael@paquier.xyz>,
        Justin Pryzby <pryzby@telsasoft.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Shruthi Gowda <gowdashru@gmail.com>
Subject: Re: pg15b2: large objects lost on upgrade
In-reply-to: 
 <CA+Tgmoa=Hd7N3oDSWnh+SOY-zu6+2ZgLTrQA6Hg6v-4sCDW=DA@mail.gmail.com>
References: 
 <CA+TgmobwWGO98mWB1X2xpo25gatKsjpENtnYaUFcvVs7raRQPg@mail.gmail.com>
 <20220702154917.GM13040@telsasoft.com>
 <CA+Tgmobg=5hAVCcTD2277AiuqCL0Vp38ETepuR2hAxeqSyR9kg@mail.gmail.com>
 <Ysc++/F+TrZ931il@momjian.us>
 <CA+TgmoZtAeh0Si0HxD0NxCqb2u99aURvCXVPyqyqD2O-0tScBQ@mail.gmail.com>
 <Yst9Wc/sWyMz4eff@paquier.xyz>
 <CA+Tgmobpm++X2g+SK6wqfHyTmyNcapoQtZbHJFMs-aq3ije=Aw@mail.gmail.com>
 <CA+TgmoZsBHG_YWHwi3ymwS9Fiuxxc82YkrUc5PvkrtMAeqXEWg@mail.gmail.com>
 <CA+TgmoYYMXGUJO5GZk1-MByJGu_bB8CbOL6GJQC8=Bzt6x6vDg@mail.gmail.com>
 <CA+TgmoYXMGtEXgX06acfLG2X3qXFf2n4btvN7pF0QLXSQF2T9Q@mail.gmail.com>
 <YuCQQtF2p3qWs7t+@momjian.us>
 <CA+Tgmob6_NTj-euMShhcnAB_=CnkRO7-UgXVfWs4fACuDk8uAA@mail.gmail.com>
 <3901843.1659116952@sss.pgh.pa.us>
 <CA+TgmobzCRWG=_Tf0VXvF26pZbTxV-CKPNx6RdoWonKPETLvyQ@mail.gmail.com>
 <CA+TgmoYKVbB9rt2UAvaFLG-qYCgRuhAr7wPLDwTT0VpbPKvj_w@mail.gmail.com>
 <CA+TgmoZiBP2OD9POF0R2L=fib4ueOUusSVzmnO0_+kNzqSpnKw@mail.gmail.com>
 <4152163.1659124804@sss.pgh.pa.us> <CA+TgmoZX6Zz4KU2e!
 nOYyc+aQWA+S5ZaZRGo6BgxW7mNF4btqaw@mail.gmail.com>
 <125444.1659136594@sss.pgh.pa.us>
 <CA+Tgmoa=Hd7N3oDSWnh+SOY-zu6+2ZgLTrQA6Hg6v-4sCDW=DA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 29 Jul 2022 19:36:14 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <135633.1659139371.1@sss.pgh.pa.us>
Date: Fri, 29 Jul 2022 20:02:51 -0400
Message-ID: <135634.1659139371@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/135634.1659139371%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Jul 29, 2022 at 7:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I am suspicious that the problem stems from the nonstandard
>> way you've invoked psql to collect the horizon data.

> Well, I just copied the pg_dump block which occurs directly beforehand
> and modified it. I think that must take care of setting the path
> properly, else we'd have things blowing up all over the place. But the
> lack of -X could be an issue.

Hmm.  Now that I look, I do see two pre-existing "naked" invocations
of psql in 002_pg_upgrade.pl, ie

	$oldnode->command_ok([ 'psql', '-X', '-f', $olddumpfile, 'postgres' ],
		'loaded old dump file');

	$oldnode->command_ok(
		[
			'psql', '-X',
			'-f', "$srcdir/src/bin/pg_upgrade/upgrade_adapt.sql",
			'regression'
		],
		'ran adapt script');

Those suggest that maybe all you need is -X.  However, I don't think
either of those calls is reached by the majority of buildfarm animals,
only ones that are doing cross-version-upgrade tests.  So there
could be more secret sauce needed to get this to pass everywhere.

Personally I'd try to replace the two horizon-collection steps with
$newnode->psql calls, using extra_params to inject the '-o' and target
filename command line words.  But if you want to try adding -X as
a quicker answer, maybe that will be enough.

			regards, tom lane