Message-ID: <1356840827.20017.15.camel@vanquo.pezone.net>
Subject: Re: Event Triggers: adding information
From: Peter Eisentraut <peter_e@gmx.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, PostgreSQL Hackers
	<pgsql-hackers@postgresql.org>
Date: Sat, 29 Dec 2012 23:13:47 -0500
In-Reply-To: 
 <CA+TgmoZTxXGAkoyQD0aNOyju1X19SnVfk7KV9fsJCv63bS-C4g@mail.gmail.com>
References: <m2txrsdzxa.fsf@2ndQuadrant.fr> <m2zk1j9c44.fsf@2ndQuadrant.fr>
	<CA+Tgmob6kmAySE5yXvd3uE9LifHunufMg9iU3GmbJ5bpGPiHjQ@mail.gmail.com>
	<m2k3sbe51z.fsf@2ndQuadrant.fr>
	<CA+TgmoZjOACnHOKrz-eucj3FJXrYJzA-_yjSqajOQR8qkjCi=w@mail.gmail.com>
	<m2bodi55yn.fsf@2ndQuadrant.fr>
	<CA+TgmoZTxXGAkoyQD0aNOyju1X19SnVfk7KV9fsJCv63bS-C4g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Sat, 2012-12-29 at 08:11 -0500, Robert Haas wrote:
> On Tue, Dec 25, 2012 at 1:42 PM, Dimitri Fontaine
> <dimitri@2ndquadrant.fr> wrote:
> > Robert Haas <robertmhaas@gmail.com> writes:
> >>> Also, keep in mind we want the ObjectID in all CREATE, ALTER and DROP
> >>> statements, so my current patch is still some bricks shy of a load… (I
> >>> added ObjectID only in the commands I added rewrite support for, apart
> >>> from DROP).
> >>
> >> I shall rely on you to provide those bricks which are still missing.
> >
> > Please find attached a patch to change most functions called from
> > standard_ProcessUtility() to return an Oid (passes `make
> > maintainer-clean; configure; make install check`). Most of them only,
> > because it only make sense for functions touching an object that exists
> > in the catalogs and have a distinct Oid.
> 
> OK, I committed this.

There is a new compiler warning coming from this, I believe:

copy.c: In function ‘DoCopy’:
copy.c:835:2: error: ‘relid’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return relid;
  ^
copy.c:753:6: note: ‘relid’ was declared here
  Oid         relid;
      ^


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers