From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Amit Kapila <amit.kapila16@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Simon Riggs <simon.riggs@enterprisedb.com>
Subject: Re: logical replication of truncate command with trigger causes
 Assert
In-reply-to: <C6BE98EB-158D-4130-9E1C-C3DCFAE0A023@enterprisedb.com>
References: <B4A3AF82-79ED-4F4C-A4E5-CD2622098972@enterprisedb.com>
 <1250962.1623192946@sss.pgh.pa.us>
 <CBED95D4-5072-4A16-9271-72AB73478817@enterprisedb.com>
 <1254157.1623196736@sss.pgh.pa.us>
 <CAA4eK1+DgDdrcxQkB7s-_PmReJB7HiaFrU2PyCzqGStOwiCVPA@mail.gmail.com>
 <1356183.1623250358@sss.pgh.pa.us>
 <C6BE98EB-158D-4130-9E1C-C3DCFAE0A023@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Wed, 09 Jun 2021 08:14:25 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1357802.1623252212.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 09 Jun 2021 11:23:32 -0400
Message-ID: <1357803.1623252212@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1357803.1623252212%40sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
>> On Jun 9, 2021, at 7:52 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Somewhat unrelated, but ... am I reading the code correctly that
>> apply_handle_stream_start and related routines are using Asserts
>> to check that the remote sent stream-control messages in the correct
>> order?  That seems many degrees short of acceptable.

> Even if you weren't reading that correctly, this bit:

>     xid =3D pq_getmsgint(s, 4);

>     Assert(TransactionIdIsValid(xid));

> simply asserts that the sending server didn't send an invalid subtransac=
tion id.

Ugh, yeah.  We should never be using Asserts to validate incoming
messages -- a test-and-elog is more appropriate.

			regards, tom lane