Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jH6Fn-0005Bs-9u for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Mar 2020 13:39:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jH6Fm-0003Gs-39 for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Mar 2020 13:39:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jH6Fk-0003FI-PR for pgsql-hackers@lists.postgresql.org; Wed, 25 Mar 2020 13:39:29 +0000 Received: from [66.111.4.27] (helo=out3-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jH6Fh-0007em-Aw for pgsql-hackers@postgresql.org; Wed, 25 Mar 2020 13:39:27 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 462735C0218; Wed, 25 Mar 2020 09:39:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Mar 2020 09:39:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gnD3nyBlhm/qvMfnb0wfdk73x0SvKhaghUp0rew5W wo=; b=WGIinLQjghUQbThDWadzLXdd48t9E6YIVY7o5C4P1GIYvak9HdkNRDvMW u7YNtuHfER1RZQMkq23h/WyTjWKoYMIe8jd2Wu+O4O9NVR0qaliFiBON5bswn1cg BxSnds98TpJ2wDAcMzfDn3ckK7T+TlB8lwjgilMAuD0NgU98V0rwkj39jLgcfxFV X8fZuSqE6xCI/OhTzirT6Tf3iJHDKu0x315AtCmYEYpeqM897a5PzuYzDqW04k9l B3i16R4NbCB9g7oaexTtMVm82MHYkhy2J4MLrcWIK20zSeqUDC8PKw2iM1lzgg13 ed9mHACLsLC9Cr4vtDALORaX1iDBw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehgedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvfhfhfhokffffgggjggtgfesth ejredttdefjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgv rhdrvghishgvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhmqeenucffohhmrg hinhepvdhnughquhgrughrrghnthdrtghomhenucfkphepleefrddvgedvrddvudefrddv gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepph gvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhm X-ME-Proxy: Received: from april.pezone.net (p5df2d5f1.dip0.t-ipconnect.de [93.242.213.241]) by mail.messagingengine.com (Postfix) with ESMTPA id 5DFDE328006A; Wed, 25 Mar 2020 09:39:13 -0400 (EDT) Subject: Re: where EXEC_BACKEND is defined To: Tom Lane References: <16021.1584722167@sss.pgh.pa.us> Cc: pgsql-hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <137138ca-68bb-0741-a47d-6e5cb45c9c40@2ndquadrant.com> Date: Wed, 25 Mar 2020 14:39:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <16021.1584722167@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.27 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-03-20 17:36, Tom Lane wrote: > One small point is that I believe the existing code has the effect of > "#define EXEC_BACKEND 1" not just "#define EXEC_BACKEND". I don't > think this matters to anyplace in the core code, but it's conceivable > that somebody has extension code written to assume the former. > Nonetheless, I'm +1 for re-standardizing on the latter, because it's > a couple less keystrokes when inserting a manual definition ;-). > Might be worth mentioning in the commit log entry though. Ok, done that way. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services