From: Tom Lane <tgl@sss.pgh.pa.us>
To: Anna Akenteva <a.akenteva@postgrespro.ru>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, a.korotkov@postgrespro.ru,
        i.kartyshov@postgrespro.ru, amit.kapila16@gmail.com,
        pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed
In-reply-to: <d3ff2e363af60b345f82396992595a03@postgrespro.ru>
References: 
 <CAPpHfdt-_MZkW2eJHP_cQsPkZVH-nF4rt6gLEj+V2XnM+2ZPiw@mail.gmail.com>
 <ccdc6c31218f61a2970c84cc850c8a41@postgrespro.ru>
 <CAPpHfdsAFR9M2oqadn4q8AeJt5ZX0uvbdQCwTOHtrEL+_OxvBw@mail.gmail.com>
 <20200408.100945.375702947246835193.horikyota.ntt@gmail.com>
 <d3ff2e363af60b345f82396992595a03@postgrespro.ru>
Comments: In-reply-to Anna Akenteva <a.akenteva@postgrespro.ru>
	message dated "Wed, 08 Apr 2020 22:36:28 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13715.1586378146.1@sss.pgh.pa.us>
Date: Wed, 08 Apr 2020 16:35:46 -0400
Message-ID: <13716.1586378146@sss.pgh.pa.us>
Precedence: bulk

Anna Akenteva <a.akenteva@postgrespro.ru> writes:
> I'd like to hear others' opinions on the syntax as well.

Pardon me for coming very late to the party, but it seems like there are
other questions that ought to be answered before we worry about any of
this.  Why is this getting grafted onto BEGIN/START TRANSACTION in the
first place?  It seems like it would be just as useful as a separate
command, if not more so.  You could always start a transaction just
after waiting.  Conversely, there might be reasons to want to wait
within an already-started transaction.

If it could survive as a separate command, then I'd humbly suggest
that it requires no grammar work at all.  You could just invent one
or more functions that take suitable parameters.

			regards, tom lane