Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UpVW2-0002XH-KU for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Jun 2013 03:26:30 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1UpVW2-0002YE-3C for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Jun 2013 03:26:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UpVW0-0002Wd-84 for pgsql-hackers@postgresql.org; Thu, 20 Jun 2013 03:26:28 +0000 Received: from mout.gmx.net ([212.227.17.22]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UpVVx-0003YV-KR for pgsql-hackers@postgresql.org; Thu, 20 Jun 2013 03:26:27 +0000 Received: from mailout-de.gmx.net ([10.1.76.27]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MQbf1-1UkBVF0C57-00U3KZ for ; Thu, 20 Jun 2013 05:26:24 +0200 Received: (qmail invoked by alias); 20 Jun 2013 03:26:23 -0000 Received: from pool-108-2-72-47.phlapa.fios.verizon.net (EHLO [192.168.1.8]) [108.2.72.47] by mail.gmx.net (mp027) with SMTP; 20 Jun 2013 05:26:23 +0200 X-Authenticated: #495269 X-Provags-ID: V01U2FsdGVkX1/SxHdFCp3SkOeAJzj0fKFxCsUVHXI65ld2GsvmYE 9glszBEXle4v0h Message-ID: <1371698781.13762.48.camel@vanquo.pezone.net> Subject: Re: Bugfix and new feature for PGXS From: Peter Eisentraut To: cedric@2ndquadrant.com Cc: pgsql-hackers@postgresql.org, Andrew Dunstan , Craig Ringer Date: Wed, 19 Jun 2013 23:26:21 -0400 In-Reply-To: <201306192058.23832.cedric@2ndquadrant.com> References: <201306181552.36673.cedric@2ndquadrant.com> <201306191832.25310.cedric@2ndquadrant.com> <51C1E0D5.5070008@dunslane.net> <201306192058.23832.cedric@2ndquadrant.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 X-Pg-Spam-Score: -3.2 (---) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Wed, 2013-06-19 at 20:58 +0200, Cédric Villemain wrote: > I believe he answered the proposal to put all headers on the same flat > directory, instead of a tree. The headers are used as #include "hstore.h" #include "ltree.h" etc. in the existing source code. If you want to install the for use by others, you can do one of three things: 1) Install them into $(pg_config --includedir-server), so other users will just include them in the same way as shown above. 2) Install them in a different directory, but keep the same #include lines. That would require PGXS changes, perhaps a new pg_config option, or something that produces the right -I option to find them. 3) Install them in a different directory and require a different #include line. But then you have to change the existing uses as well, which would probably require moving files around. Both 2 and 3 require a lot of work, possibly compatibility breaks, for no obvious reason. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers