From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Coleman <jtc331@gmail.com>
cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Michael Paquier <michael@paquier.xyz>,
        Rafia Sabih <rafia.pghackers@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        Simon Riggs <simon@2ndquadrant.com>,
        Shaun Thomas <shaun.thomas@2ndquadrant.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Alexander Korotkov <a.korotkov@postgrespro.ru>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
        Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
In-reply-to: 
 <CAAaqYe_kpBUEkKXLRYfspu05p0wgj_n3_tORStDfCvLUpWUbRA@mail.gmail.com>
References: 
 <CAAaqYe9szJ9=a-ayZUuLbV8rBh3YYgxtCHzdh5Mo2xMS7NL=rQ@mail.gmail.com>
 <20190721113422.hjubqs45xxpnldn7@development>
 <20190730001711.hprrcx3ntk57wuqv@development>
 <CA+FpmFfEJZ=obUpjgXO5u3T1yzqPh3CPsyfjhEN9_L31NDPHqA@mail.gmail.com>
 <20190904191710.gogtnktjbvtg5zq3@development>
 <20190909215538.42hrv6j4z5ztcft4@development>
 <CAAaqYe-L4a2mj=AqguVjdkf65LZ772C-GbKgAj7CQro8rftXBg@mail.gmail.com>
 <20190928230049.k4l2mayun7jomhxy@development>
 <20191129060146.GH2505@paquier.xyz>
 <20191201004716.cenkc33em2lnrrdl@development>
 <20200121142529.wpickvfefp7lok4p@development>
 <CAAaqYe-=w0RaadtaTxfwuVa7GK+8QS7D51YzmfJLX9YZGfqc4A@mail.gmail.com>
 <CAAaqYe_kpBUEkKXLRYfspu05p0wgj_n3_tORStDfCvLUpWUbRA@mail.gmail.com>
Comments: In-reply-to James Coleman <jtc331@gmail.com>
	message dated "Thu, 05 Mar 2020 17:01:06 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13717.1583448772.1@sss.pgh.pa.us>
Date: Thu, 05 Mar 2020 17:52:52 -0500
Message-ID: <13718.1583448772@sss.pgh.pa.us>
Precedence: bulk

James Coleman <jtc331@gmail.com> writes:
> I'm looking at this now, and realized that at least for parallel plans the
> current patch tracks the tuplesort instrumentation whether or not an
> EXPLAIN ANALYZE is in process.

> Is this fairly standard for executor nodes? Or is it expected to condition
> some of this tracking based on whether or not an ANALYZE is running?

No, it's entirely not standard.  Maybe you could make an argument that
it's too cheap to bother making it conditional, but without a convincing
argument for that, it needs to be conditional.

			regards, tom lane