From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: PRI?64 vs Visual Studio (2022)
In-reply-to: 
 <CA+hUKGJnmzTqiODmTjf-23yZ=E3HXqFTtKoyp3TF-MpB93hTMQ@mail.gmail.com>
References: <20250331.152829.1921392690375275165.horikyota.ntt@gmail.com>
 <001bdc3b-ef94-4f24-b017-ac8ff0a2ea55@eisentraut.org>
 <CA+hUKGJnmzTqiODmTjf-23yZ=E3HXqFTtKoyp3TF-MpB93hTMQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Wed, 19 Nov 2025 15:13:54 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1372792.1763519315.1@sss.pgh.pa.us>
Date: Tue, 18 Nov 2025 21:28:35 -0500
Message-ID: <1372793.1763519315@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1372793.1763519315%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> We don't even test -Dnls on the Windows CI task, so the fact that it
> passes there doesn't mean much (if our tests would even pick up
> <PRI*64> expansion failure, not sure).  We should probably do
> something about that and/or its absence from the build farm.  We're
> effectively counting on the EDB packaging team or end users to tell us
> if we break localisation on this platform.

I'm pretty certain that we do not test NLS localization at all,
anywhere :-(.  (There are no test cases checking enable_nls,
which would be a necessary thing to not fail on buildfarm critters
not using NLS.)

I agree that starting to rely on PRI?64 in translatable strings
is raising the bar a good deal, so maybe it's time to do something
about that.

			regards, tom lane