From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: PRI?64 vs Visual Studio (2022)
In-reply-to: 
 <CA+hUKGLzXzQcbjEHW08Z6g=mzBkpLtzSJ7Bt2S2XmxP1bwpq8A@mail.gmail.com>
References: <20250331.152829.1921392690375275165.horikyota.ntt@gmail.com>
 <001bdc3b-ef94-4f24-b017-ac8ff0a2ea55@eisentraut.org>
 <CA+hUKGJnmzTqiODmTjf-23yZ=E3HXqFTtKoyp3TF-MpB93hTMQ@mail.gmail.com>
 <1372793.1763519315@sss.pgh.pa.us>
 <CA+hUKGLzXzQcbjEHW08Z6g=mzBkpLtzSJ7Bt2S2XmxP1bwpq8A@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Wed, 19 Nov 2025 15:50:44 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1377511.1763522154.1@sss.pgh.pa.us>
Date: Tue, 18 Nov 2025 22:15:54 -0500
Message-ID: <1377512.1763522154@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1377512.1763522154%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Perhaps meson/configure should do a po -> mo -> gettext() check with a
> canned test message?  That'd also make sure your msgfmt and libintl
> are compatible, something I worried about when I wrote about musl
> recently.

No, I don't think that's a good approach.  That is testing the library
available at configure time, not the one you are actually running
with (possibly years later and on a different machine, even without
considering cross-compilation cases).  I think we should do it
honestly with a regression test.  It doesn't need to be very
complicated --- I think checking one message in one translation is
sufficient, so long as it includes a PRI?64 usage.

			regards, tom lane