Message-ID: <1381193255.25702.4.camel@vanquo.pezone.net>
Subject: Re: Bugfix and new feature for PGXS
From: Peter Eisentraut <peter_e@gmx.net>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org, Josh Berkus
 <josh@agliodbs.com>, Robert Haas <robertmhaas@gmail.com>, Craig Ringer
 <craig@2ndquadrant.com>
Date: Mon, 07 Oct 2013 20:47:35 -0400
In-Reply-To: <5248B32E.1090001@dunslane.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <51DB171F.2090108@dunslane.net> <201307122350.23726.cedric@2ndquadrant.com>
 <1739933.FyLmpy7Q73@obelix> <5248B32E.1090001@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote:
> On 09/03/2013 04:04 AM, C=C3=A9dric Villemain wrote:
> >> Simple one, attached.
> >> I didn't document USE_VPATH, not sure how to explain that clearly.
> > Just a remember that the doc is written and is waiting to be commited.
> >
> > There is also an issue spoted by Christoph with the installdirs prerequ=
isite,
> > the attached patch fix that.
> >
>=20
> I applied this one line version of the patch, which seemed more elegant=20
> than the later one supplied.
>=20
> I backpatched that and the rest of the VPATH changes for extensiuons to=20
> 9.1 where we first provided for extensions, so people can have a=20
> reasonably uniform build system for their extensions.

I suspect this line

submake-libpq: $(libdir)/libpq.so ;

will cause problems on platforms with a different extension (e.g. OS X).

Given that this supposedly small and noninvasive set of changes has
caused a number of problems already, I suggest we revert this entire
thing until we have had time to actually test it somewhere other than in
the the stable branches.  As it stands, it is a new feature being
developed in the stable branches, which is clearly not acceptable.


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers