Message-ID: <1381453766.5264.11.camel@vanquo.pezone.net>
Subject: Re: GIN improvements part 1: additional information
From: Peter Eisentraut <peter_e@gmx.net>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, pgsql-hackers
 <pgsql-hackers@postgresql.org>
Date: Thu, 10 Oct 2013 21:09:26 -0400
In-Reply-To: <52545362.4080806@vmware.com>
References: 
 <CAPpHfduxv-iL7aedwPW0W5fXrWGAKfxijWM63_hZujaCRxnmFQ@mail.gmail.com>
 <CAPpHfduQrtC4B+MC9_z3QB8oJsK1Ws-H8ivEsy_cmDnfoJqkeQ@mail.gmail.com>
 <CAPpHfdszEJhSynTPX6=tB3aKq1EA1JXpwx4xiFYM097K7PhQLA@mail.gmail.com>
 <CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
 <51CEA13C.8040103@vmware.com>
 <CAPpHfdutJEC9+6vWX579afZKzdHKCT2wzDkAEom1XmiXEwF3pw@mail.gmail.com>
 <524E7C3B.7060402@vmware.com>
 <CAPpHfdvMNt0-Wi4bausBCYiXcYuuzU5Ha7SZPaB6u61xY2E_Og@mail.gmail.com>
 <52545362.4080806@vmware.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

You linked to this email from the commitfest entry, but there is no
patch here.  You probably meant a different email.  Check please.


On Tue, 2013-10-08 at 21:48 +0300, Heikki Linnakangas wrote:
> On 04.10.2013 14:13, Alexander Korotkov wrote:
> > On Fri, Oct 4, 2013 at 12:28 PM, Heikki Linnakangas<hlinnakangas@vmware.com
> >> wrote:
> >
> >> In the attached patch, I in fact already did that for data leaf pages, but
> >> didn't change the format of non-leaf pages yet. If we want to support
> >> pg_upgrade, we might want to refrain from changing the non-leaf format.
> >
> > In GinDataLeafPageGetPostingList* you use sizeof(ItemPointerData) without
> > MAXALIGN. Is it an error or you especially use 2 extra bytes on leaf page?
> 
> I didn't even think of it. Now that I do think of it, I don't see a 
> reason to use MAXALIGN there. PostingItems only require 2-byte 
> alignment. It's a bit fragile and underdocumented though. It probably 
> would be good to have a struct to represent that layout. Something like:
> 
> struct
> {
>    ItemPointerData rightBound;
>    PostingItem postingItems[1]; /* variable length array */
> } PostingItemPageContent;
> 
> And use that struct in the macros.
> 
> Then again, we do currently use MAXALIGN there, so if we want to avoid 
> changing the on-disk format, we have to keep it...
> 
> - Heikki
> 
> 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers