Message-ID: <1381455307.5264.14.camel@vanquo.pezone.net>
Subject: Re: Bugfix and new feature for PGXS
From: Peter Eisentraut <peter_e@gmx.net>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org, Josh Berkus
 <josh@agliodbs.com>, Robert Haas <robertmhaas@gmail.com>, Craig Ringer
 <craig@2ndquadrant.com>
Date: Thu, 10 Oct 2013 21:35:07 -0400
In-Reply-To: <525410EC.9010002@dunslane.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <51DB171F.2090108@dunslane.net>
 <201307122350.23726.cedric@2ndquadrant.com>  <1739933.FyLmpy7Q73@obelix>
 <5248B32E.1090001@dunslane.net>
 <1381193255.25702.4.camel@vanquo.pezone.net>
 <525410EC.9010002@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
> On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
> >
> > I suspect this line
> >
> > submake-libpq: $(libdir)/libpq.so ;
> >
> > will cause problems on platforms with a different extension (e.g. OS X).
> 
> 
> suggested fix is below.

Hmm, this would duplicate information about shared library naming in a
place outside of Makefile.shlib.  That doesn't look right.


> diff --git a/src/Makefile.global.in b/src/Makefile.global.in
> index bb732bb..b562378 100644
> --- a/src/Makefile.global.in
> +++ b/src/Makefile.global.in
> @@ -422,7 +422,11 @@ ifndef PGXS
>   submake-libpq:
>      $(MAKE) -C $(libpq_builddir) all
>   else
> -submake-libpq: $(libdir)/libpq.so ;
> +ifneq ($(PORTNAME),cygwin)
> +submake-libpq: $(libdir)/libpq$(DLSUFFIX) ;
> +else
> +submake-libpq: $(libdir)/cygpq$(DLSUFFIX) ;
> +endif
>   endif
> 
>   ifndef PGXS
> 
> 
> 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers