Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oK838-0000aK-Gr for pgsql-hackers@arkaria.postgresql.org; Sat, 06 Aug 2022 00:52:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oK837-0000Ra-6o for pgsql-hackers@arkaria.postgresql.org; Sat, 06 Aug 2022 00:52:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oK836-0000Mg-Su for pgsql-hackers@lists.postgresql.org; Sat, 06 Aug 2022 00:52:16 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oK830-0007J8-Ed for pgsql-hackers@postgresql.org; Sat, 06 Aug 2022 00:52:16 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2760q4wS013818; Fri, 5 Aug 2022 20:52:04 -0400 From: Tom Lane To: Andres Freund cc: Thomas Munro , Andrew Dunstan , Robert Haas , pgsql-hackers Subject: Re: Cleaning up historical portability baggage In-reply-to: <20220806000311.ywx65iuchvj4qn2k@awork3.anarazel.de> References: <1249825.1658622186@sss.pgh.pa.us> <20220804013546.h65najrzig764jar@awork3.anarazel.de> <3295936.1659577924@sss.pgh.pa.us> <20220804023010.24snkyq3hser5pxq@awork3.anarazel.de> <20220805210823.u546w4p4wzfany7p@awork3.anarazel.de> <20220806000311.ywx65iuchvj4qn2k@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 05 Aug 2022 17:03:11 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13816.1659747124.1@sss.pgh.pa.us> Date: Fri, 05 Aug 2022 20:52:04 -0400 Message-ID: <13817.1659747124@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > I've renamed the file to win32gettimeofday now. I wonder if we should rename > files that are specific to msvc to indicate that? But that's for later. +1, but you didn't change the file's own comments containing its name. regards, tom lane