Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnReR-0006FX-Nx for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 14:40:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bnReQ-0002wG-Q0 for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 14:40:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bnRd3-0001KJ-4s for pgsql-hackers@postgresql.org; Fri, 23 Sep 2016 14:39:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bnRcz-0000S0-If for pgsql-hackers@postgresql.org; Fri, 23 Sep 2016 14:39:04 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u8NEcvJ9013888; Fri, 23 Sep 2016 10:38:57 -0400 From: Tom Lane To: Michael Paquier cc: Aleksander Alekseev , PostgreSQL Hackers Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c In-reply-to: References: <20160923090814.GB1238@e733> <20160923095431.GD1238@e733> Comments: In-reply-to Michael Paquier message dated "Fri, 23 Sep 2016 22:46:10 +0900" Date: Fri, 23 Sep 2016 10:38:57 -0400 Message-ID: <13887.1474641537@sss.pgh.pa.us> X-Pg-Spam-Score: -5.0 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Michael Paquier writes: > On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev > wrote: >>> Very simple small patch - see attachment. >>> >>> /* not expected, but print something anyway */ >>> else if (msg->id == SHAREDINVALRELMAP_ID) >>> - appendStringInfoString(buf, " relmap"); >>> - else if (msg->id == SHAREDINVALRELMAP_ID) >>> appendStringInfo(buf, " relmap db %u", msg->rm.dbId); > Not really but my guess is that the two conditions have been left for > this purpose. I think it's a pretty obvious copy-and-pasteo. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers