Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRTQV-0006ea-Nq for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Nov 2019 03:53:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iRTQS-0005tc-8Y for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Nov 2019 03:53:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRTQS-0005tV-00 for pgsql-hackers@lists.postgresql.org; Mon, 04 Nov 2019 03:53:08 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRTQO-0007k7-Kh for pgsql-hackers@lists.postgresql.org; Mon, 04 Nov 2019 03:53:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xA43r0HN013901 for ; Sun, 3 Nov 2019 22:53:00 -0500 From: Tom Lane To: pgsql-hackers@lists.postgresql.org Subject: TAP tests aren't using the magic words for Windows file access MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13899.1572839580.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 03 Nov 2019 22:53:00 -0500 Message-ID: <13900.1572839580@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Buildfarm member drongo has been failing the pg_ctl regression test pretty often. I happened to look closer at what's happening, and it's this: could not read "C:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_ctl/tmp_check/= t_004_logrotate_primary_data/pgdata/current_logfiles": Permission denied a= t C:/prog/bf/root/HEAD/pgsql.build/src/test/perl/TestLib.pm line 397. That is, TestLib::slurp_file is failing to read a file. Almost certainly, "permission denied" doesn't really mean a permissions problem, but failure to specify the file-opening flags needed to allow concurrent access on Windows. We fixed this in pg_ctl itself in commit 0ba06e0bf ... but we didn't fix the TAP infrastructure. Is there an easy way to get Perl on board with that? regards, tom lane