Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crbxX-0004GU-AX for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Mar 2017 03:01:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1crbxW-0003Zk-8e for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Mar 2017 03:01:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1crbxU-0003ZY-AW for pgsql-hackers@postgresql.org; Sat, 25 Mar 2017 03:01:40 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1crbxN-0002UN-Eg for pgsql-hackers@postgresql.org; Sat, 25 Mar 2017 03:01:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2P31JED013919; Fri, 24 Mar 2017 23:01:19 -0400 From: Tom Lane To: Andres Freund cc: Heikki Linnakangas , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: WIP: Faster Expression Processing v4 In-reply-to: <22833.1490390175@sss.pgh.pa.us> References: <28270.1490289299@sss.pgh.pa.us> <20170323174004.a2ez7kygx5ngqxlp@alap3.anarazel.de> <8011.1490305255@sss.pgh.pa.us> <26088.1490315792@sss.pgh.pa.us> <20170324004734.3a2dokbfofiz6ylu@alap3.anarazel.de> <30270.1490318779@sss.pgh.pa.us> <20170324013412.qy7ltnnqv5m7qiuc@alap3.anarazel.de> <31825.1490320683@sss.pgh.pa.us> <20170324020003.4rt63xty7xpb4akq@alap3.anarazel.de> <22215.1490369187@sss.pgh.pa.us> <20170324182742.3r4qndpugtx6ga3t@alap3.anarazel.de> <22833.1490390175@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Fri, 24 Mar 2017 17:16:15 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13917.1490410879.1@sss.pgh.pa.us> Date: Fri, 24 Mar 2017 23:01:19 -0400 Message-ID: <13918.1490410879@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org btw ... I just got around to looking at a code coverage report for this patched version, and that reminded me of something I'd already suspected: EEOP_INNER_SYSVAR and EEOP_OUTER_SYSVAR seem to be dead code. That's unsurprising, because we never try to access a tuple's system columns above the scan level. If a query asks for system columns, those get passed up to upper query levels as ordinary user-side columns. We could keep the execution support for those opcodes, or we could rip it out and throw an error in execExpr.c if one would need to be generated. I'm a little inclined to the latter, because it seems like the plan is to grow more support for every opcode in the future. We don't need to be adding support for unreachable opcodes. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers