From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew@dunslane.net>,
        Bruce Momjian <bruce@momjian.us>,
        Michael Paquier <michael@paquier.xyz>,
        Justin Pryzby <pryzby@telsasoft.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Shruthi Gowda <gowdashru@gmail.com>
Subject: Re: pg15b2: large objects lost on upgrade
In-reply-to: 
 <CA+TgmoaGBbpzgu3=du1f9zDUbkfycO0y=_uWrLFy=KKEqXWeLQ@mail.gmail.com>
References: 
 <CA+TgmobwWGO98mWB1X2xpo25gatKsjpENtnYaUFcvVs7raRQPg@mail.gmail.com>
 <20220702154917.GM13040@telsasoft.com>
 <CA+Tgmobg=5hAVCcTD2277AiuqCL0Vp38ETepuR2hAxeqSyR9kg@mail.gmail.com>
 <Ysc++/F+TrZ931il@momjian.us>
 <CA+TgmoZtAeh0Si0HxD0NxCqb2u99aURvCXVPyqyqD2O-0tScBQ@mail.gmail.com>
 <Yst9Wc/sWyMz4eff@paquier.xyz>
 <CA+Tgmobpm++X2g+SK6wqfHyTmyNcapoQtZbHJFMs-aq3ije=Aw@mail.gmail.com>
 <CA+TgmoZsBHG_YWHwi3ymwS9Fiuxxc82YkrUc5PvkrtMAeqXEWg@mail.gmail.com>
 <CA+TgmoYYMXGUJO5GZk1-MByJGu_bB8CbOL6GJQC8=Bzt6x6vDg@mail.gmail.com>
 <CA+TgmoYXMGtEXgX06acfLG2X3qXFf2n4btvN7pF0QLXSQF2T9Q@mail.gmail.com>
 <YuCQQtF2p3qWs7t+@momjian.us>
 <CA+Tgmob6_NTj-euMShhcnAB_=CnkRO7-UgXVfWs4fACuDk8uAA@mail.gmail.com>
 <3901843.1659116952@sss.pgh.pa.us>
 <CA+TgmobzCRWG=_Tf0VXvF26pZbTxV-CKPNx6RdoWonKPETLvyQ@mail.gmail.com>
 <CA+TgmoYKVbB9rt2UAvaFLG-qYCgRuhAr7wPLDwTT0VpbPKvj_w@mail.gmail.com>
 <CA+TgmoZiBP2OD9POF0R2L=fib4ueOUusSVzmnO0_+kNzqSpnKw@mail.gmail.com>
 <4152163.1659124804@sss.pgh.pa.us> <125444.1659136594!
 @sss.pgh.pa.us>
 <CA+Tgmoa=Hd7N3oDSWnh+SOY-zu6+2ZgLTrQA6Hg6v-4sCDW=DA@mail.gmail.com>
 <135634.1659139371@sss.pgh.pa.us>
 <CA+TgmoaGBbpzgu3=du1f9zDUbkfycO0y=_uWrLFy=KKEqXWeLQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 29 Jul 2022 20:08:02 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <139503.1659140555.1@sss.pgh.pa.us>
Date: Fri, 29 Jul 2022 20:22:35 -0400
Message-ID: <139504.1659140555@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/139504.1659140555%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> Here's a patch that uses a variant of that approach: it just runs
> safe_psql straight up and gets the output, then writes it out to temp
> files if the output doesn't match and we need to run diff. Let me know
> what you think of this.

That looks good to me, although obviously I don't know for sure
if it will make wrasse happy.

> While working on this, I noticed a few other problems. One is that the
> query doesn't have an ORDER BY clause, which it really should, or the
> output won't be stable. And the other is that I think we should be
> testing against the regression database, not the postgres database,
> because it's got a bunch of user tables in it, not just
> pg_largeobject.

Both of those sound like "d'oh" observations to me.  +1

			regards, tom lane