Feedback-ID: ie0a040ee:Fastmail
Message-ID: <1397d468-9d00-40b3-9f92-da73d4ae50ad@eisentraut.org>
Date: Thu, 4 Jun 2026 11:58:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that
 depend on the range column
To: Paul A Jungwirth <pj@illuminatedcomputing.com>,
 Chao Li <li.evan.chao@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAHg+QDcd=t69gLf9yQexO07EJ2mx0Z70NFHo6h94X1EDA=hM0g@mail.gmail.com>
 <CACJufxEkomKYmWgqXJmQr_qS+z=BZ3w801eh7Z7ekh-3oHXxHQ@mail.gmail.com>
 <CA+renyWk7kVsZJPZKzN95mYkO7S=hDUx=+fUPtbg9qFqeepCpg@mail.gmail.com>
 <CACJufxHai+HB1gkNqVEHe4oKyUmXfAagWBYAWXYKy8hyMV3RxA@mail.gmail.com>
 <CA+renyUBQdhnYxfPay+dxFs6BU1-fnEQskT0r-3dQ2v-ZnmZzg@mail.gmail.com>
 <CA+renyVZLYSghHb_85w0pUBG0KNGKTwciFTKBK5--rpHUM+VdA@mail.gmail.com>
 <e856c439-bf96-4244-8dc3-18b2a552e406@eisentraut.org>
 <CA+renyU6rNkiNGreMyQ7pU_F6-5RND5jchHbECH4NoRO7W0Q-Q@mail.gmail.com>
 <27BD5D23-19C9-4FD1-8935-9C788C3C9869@gmail.com>
 <66C1555B-CA54-4ED1-AB4F-0EE97D24A006@gmail.com>
 <91B35E0F-5DC1-4417-A1B9-FAF4A3DCD2BD@gmail.com>
 <CA+renyUBLAynaj0BKhajB6F=sLuitQkjT+_sOt5HBSRn82iQsw@mail.gmail.com>
 <74C1863C-2C2A-423A-BDE7-0228889F1D80@gmail.com>
 <CA+renyUTzwAMar173cbbxJypChp7s=txxgB+LYJQ5oRZ3a5hYQ@mail.gmail.com>
 <CA+renyXyLfvtvVv--hGWGTgzFP=-+dPLy4RWvEmioAPyJMM+uw@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CA+renyXyLfvtvVv--hGWGTgzFP=-+dPLy4RWvEmioAPyJMM+uw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/1397d468-9d00-40b3-9f92-da73d4ae50ad%40eisentraut.org>
Precedence: bulk

On 26.05.26 00:23, Paul A Jungwirth wrote:
> On Fri, May 8, 2026 at 8:25 AM Paul A Jungwirth
> <pj@illuminatedcomputing.com> wrote:
>>
>> On Fri, May 8, 2026 at 12:10 AM Chao Li <li.evan.chao@gmail.com> wrote:
>>>> <v11-0001-Fix-FOR-PORTION-OF-column-dependency-tracking.patch><v11-0002-Fix-FOR-PORTION-OF-with-partitions-and-inheritan.patch>
>>>
>>> Thanks for updating the patch and making the separation. After reading v11, I still have a few comments for 0001.
>> . . .
>>
>> v12 attached.
> 
> After discussing this as PGConf.dev, Peter and I agreed that we
> *should* be checking for UPDATE permission on the application-time
> column. So we need to add the attno to updatedCols on the
> RTEPermissionInfo. That is great, because it fixes GENERATED column
> dependency tracking and also UPDATE OF triggers, without the
> complexity of changing ExecGetUpdatedCols.
> 
> Note we still do not require INSERT permission for the temporal
> leftovers, which is what the SQL Standard says and also makes sense
> semantically, since those leftovers represent already-existing
> history.
> 
> No RLS changes are needed because RLS policies aren't checked based on
> *column* changes.
> 
> We still need a fix for non-partitioning inheritance, but the patch
> becomes a lot simpler.
> 
> Here is a patch adding the application-time column to updatedCols,
> along with the tests we've written for GENERATED columns and UPDATE OF
> triggers.

committed