Subject: Re: Add %x to PROMPT1 and PROMPT2
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com>
 <alpine.DEB.2.21.2001261946530.29788@pseudo>
 <e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
 <alpine.DEB.2.21.2001271250190.24374@pseudo>
From: Vik Fearing <vik.fearing@2ndquadrant.com>
Message-ID: <13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com>
Date: Wed, 29 Jan 2020 23:51:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2001271250190.24374@pseudo>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 29/01/2020 08:25, Fabien COELHO wrote:
> 
> Hello Vik,
> 
>>> Isn't there examples in the documentation which use the default prompts?
>>>
>>> If so, should they be updated accordingly?
>>
>> Good catch!
>> I thought about the documentation but not the examples therein.
>>
>> Updated patch attached.
> 
> Ok.
> 
> Only one transaction prompt example in the whole documentation:-(
> No tests is troubled by the change:-(
> Sigh…
> 
> Patch applies and compiles cleanly, global and psql make check ok.
> 
> Doc build ok.
> 
> Works for me.

Thanks for the review!

Would you mind changing the status in the commitfest app?
https://commitfest.postgresql.org/27/2427/
-- 
Vik Fearing