Reply-To: jesper.pedersen@redhat.com
Subject: Re: pread() and pwrite()
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>,
 Oskari Saarenmaa <os@ohmu.fi>, Pg Hackers <pgsql-hackers@postgresql.org>,
 Tobias Oberstein <tobias.oberstein@gmail.com>
References: 
 <CAEepm=02rapCpPR3ZGF2vW=SBHSdFYO_bz_f-wwWJonmA3APgw@mail.gmail.com>
 <20180720081459.GC22214@saarenmaa.fi>
 <CAEepm=2qRXWM+uX26dPn6S=TAqi8FfuAZ9vG8tZW9Jo7w6YeQw@mail.gmail.com>
 <7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com>
 <c2f56d0a-cadd-3df1-ae48-b84dc8128c37@redhat.com>
 <CAEepm=1DZSzdBRDbXFXSiu_Hiv08f22kFmgCi7ZBRERF_=ZCPg@mail.gmail.com>
 <983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com>
 <CAEepm=15aoFSr9G25T4wP_6vTKd1bPAViu5pZtrObyviMvowpQ@mail.gmail.com>
 <19344.1539050134@sss.pgh.pa.us>
 <CAEepm=1FDQOTtpSDP+VX15t1F+cg1jOHKNs-NNM=qFYYk_0++w@mail.gmail.com>
 <21196.1539053390@sss.pgh.pa.us> <2145.1539058113@sss.pgh.pa.us>
 <CAEepm=1X9htKVEXbPZnH8ebF+Mo5kVkTZq3pg9gmdu=1Xx8rnA@mail.gmail.com>
 <4cf40b3d-96ed-7597-fb42-e5e29c5a40fe@redhat.com>
 <CAEepm=0gKm3WvzUKkfynkc6TFJ3MrfmX7MBFi9nPvDd3gTapOw@mail.gmail.com>
 <CAEepm=3QOz_BEP9tz66q6tXg=dKkXCnkzo_VcFttajgpTNTS+g@mail.gmail.com>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: Red Hat
Message-ID: <13bf4246-061f-6187-e881-547a82379f70@redhat.com>
Date: Mon, 5 Nov 2018 08:44:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: 
 <CAEepm=3QOz_BEP9tz66q6tXg=dKkXCnkzo_VcFttajgpTNTS+g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Thomas,

On 11/5/18 7:08 AM, Thomas Munro wrote:
> On Sun, Nov 4, 2018 at 12:03 AM Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> On Sat, Nov 3, 2018 at 2:07 AM Jesper Pedersen
>> <jesper.pedersen@redhat.com> wrote:
>>> This still applies, and passes make check-world.
>>>
>>> I wonder what the commit policy is on this, if the Windows part isn't
>>> included. I read Heikki's comment [1] as it would be ok to commit
>>> benefiting all platforms that has pread/pwrite.
>>
>> Here's a patch to add Windows support by supplying
>> src/backend/port/win32/pread.c.  Thoughts?
> 
> If we do that, I suppose we might as well supply implementations for
> HP-UX 10.20 as well, and then we can get rid of the conditional macro
> stuff at various call sites and use pread() and pwrite() freely.
> Here's a version that does it that way.  One question is whether the
> caveat mentioned in patch 0001 is acceptable.
> 

Passed check-world, but I can't verify the 0001 patch. Reading the the 
API it looks ok to me.

I guess the caveat in 0001 is ok, as it is a side-effect of the 
underlying API.

Best regards,
  Jesper