Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOVQG-0005mo-9u for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Mar 2021 01:01:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOVQF-0007od-1C for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Mar 2021 01:01:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOVQE-0007oV-QL for pgsql-hackers@lists.postgresql.org; Tue, 23 Mar 2021 01:01:26 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOVQC-0005MS-MN for pgsql-hackers@postgresql.org; Tue, 23 Mar 2021 01:01:25 +0000 Received: from hnk.local (p2350207-ipbf2126funabasi.chiba.ocn.ne.jp [114.167.184.207]) by oss.nttdata.com (Postfix) with ESMTPSA id 51F94628CD; Tue, 23 Mar 2021 10:01:21 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump. To: Kyotaro Horiguchi Cc: Shinya11.Kato@nttdata.com, david@pgmasters.net, movead.li@highgo.ca, pgsql-hackers@postgresql.org, andres@anarazel.de, michael@paquier.xyz, ahsan.hadi@highgo.ca References: <790571f2-7068-3717-6223-85683db74542@oss.nttdata.com> <20210322.174926.1169569387469451384.horikyota.ntt@gmail.com> From: Fujii Masao Message-ID: <13dcbbdd-14cc-26ba-214a-07ac9d88d7fe@oss.nttdata.com> Date: Tue, 23 Mar 2021 10:01:20 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322.174926.1169569387469451384.horikyota.ntt@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021/03/22 17:49, Kyotaro Horiguchi wrote: > At Mon, 22 Mar 2021 14:07:43 +0900, Fujii Masao wrote in >> >> >> On 2021/03/22 14:03, Shinya11.Kato@nttdata.com wrote: >>>> Barring any objection, I will commit this. >>> I think it's good except for a typo "thoes four bits" >> >> Thanks for the review! Attached is the updated version of the patch. > > Thanks for picking it up. LGTM and applies cleanly. Pushed. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION