From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Ronan Dunklau <ronan.dunklau@aiven.io>,
 pgsql-hackers@lists.postgresql.org,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
In-reply-to: <ZzV88-6lOrqd1LNU@paquier.xyz>
References: <3395418.1618352794@sss.pgh.pa.us> <ZywSnWzXskAxSDew@paquier.xyz>
 <ZzMSJkiNZhimjXWx@paquier.xyz> <2345099.ElGaqSPkdT@aivenlaptop>
 <ZzV88-6lOrqd1LNU@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 14 Nov 2024 13:30:43 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1400204.1734199200.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 14 Dec 2024 13:00:00 -0500
Message-ID: <1400205.1734199200@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1400205.1734199200%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Doing that step-by-step is better than nothing, hence limiting the use
> of named parameters for only the functions whose body is rewritten is
> fine by me, as a first step, as long as the names are used rather the
> dollar parameter numbers.  I'd suggest to do take the bonus step of
> applying the same rule to all the other functions so as everything
> applies with the same extension update in a single major release.
> Perhaps on top of the patches already proposed?  There is no need for
> an extra version bump if all that is done in the same development
> cycle.

FWIW, I don't agree at all with doing argument name addition in
this patchset.  Certainly that's a fine thing to do, but it's an
independent issue and should be handled in an independent patch.

I see that the cfbot is unhappy because it doesn't understand
that some of the patches have been applied already.  I am going
to go ahead and get the earthdistance one done, because we have
a live problem report about that [1].  I'll rebase and repost
the remainder afterwards.

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/6a6439f1-8039-44e2-8fb9-590=
28f7f2014%40mailbox.org