From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-hackers@lists.postgresql.org
Subject: array_cat anycompatible change is breaking xversion upgrade tests
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1401823.1604537031.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 04 Nov 2020 19:43:51 -0500
Message-ID: <1401824.1604537031@sss.pgh.pa.us>
Precedence: bulk

crake is showing xversion upgrade failures since 9e38c2bb50:

pg_restore: error: could not execute query: ERROR:  function array_cat(any=
array, anyarray) does not exist
Command was: CREATE AGGREGATE "public"."array_cat_accum"("anyarray") (
    SFUNC =3D "array_cat",
    STYPE =3D "anyarray",
    INITCOND =3D '{}'
);

As was discussed in the thread leading up to that commit, modifying the
signature of array_cat and friends could break user-defined operators
and aggregates based on those functions.  It seems to me that the
usability gain from this change is worth that cost, but it is causing
an issue for xversion tests.

I think the most plausible response is to add this aggregate to the filter
logic that already exists in the xversion tests.  Perhaps we could
alternatively change this test case so that it relies on some other
polymorphic function, but I'm not quite sure what a good candidate
would be.

			regards, tom lane