From: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <11558.1767609632@localhost>
References: <202512151349.vlq3mpfniyk3@alvherre.pgsql> <11247.1767609087@localhost> <11558.1767609632@localhost>
Comments: In-reply-to Antonin Houska <ah@cybertec.at>
   message dated "Mon, 05 Jan 2026 11:40:32 +0100."
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Thu, 08 Jan 2026 17:59:00 +0100
Message-ID: <141054.1767891540@localhost>
Archived-At: <https://www.postgresql.org/message-id/141054.1767891540%40localhost>
Precedence: bulk

--=-=-=
Content-Type: text/plain

Antonin Houska <ah@cybertec.at> wrote:

> Antonin Houska <ah@cybertec.at> wrote:
> 
> > Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> > > If we do indeed need this,
> > > then perhaps it should be done after ReorderBufferProcessXid().
> > 
> > ... and after SnapBuildProcessChange(). Thus the changes being discussed here
> > should be removed from the patch. I'll do that in the next version. Thanks.
> 
> Actually the check of XLH_DELETE_NO_LOGICAL should not be discarded. I think
> it should be added to DecodeDelete().

v29 tries to fix the problem.

Besides that, it reflects the recent Mihail's comments [1], [2].

[1]
https://www.postgresql.org/message-id/CADzfLwXp4c-MJx7yVDxAGNNxPbX4o9dqyivxavtHvmUsdXYqBQ@mail.gmail.com
[2] https://www.postgresql.org/message-id/CADzfLwWNz_jwi7KVOmJ9D97+zwxsiwDSqSUUJ9oqUCOqkbGnRA@mail.gmail.com

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename=v29-0001-Add-REPACK-command.patch
Content-Transfer-Encoding: quoted-printable