Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEM75-0007Zb-LT for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Apr 2019 22:54:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hEM74-0006xe-BD for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Apr 2019 22:54:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEM74-0006xW-2c for pgsql-hackers@lists.postgresql.org; Wed, 10 Apr 2019 22:54:38 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEM6w-0001jd-SE for pgsql-hackers@lists.postgresql.org; Wed, 10 Apr 2019 22:54:36 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x3AMsPUJ014132; Wed, 10 Apr 2019 18:54:25 -0400 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org Subject: Re: Reducing the runtime of the core regression tests In-reply-to: <20190410224830.wrshpdlt3ktjrava@alap3.anarazel.de> References: <735.1554935715@sss.pgh.pa.us> <20190410224830.wrshpdlt3ktjrava@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 10 Apr 2019 15:48:30 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14130.1554936865.1@sss.pgh.pa.us> Date: Wed, 10 Apr 2019 18:54:25 -0400 Message-ID: <14131.1554936865@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2019-04-10 18:35:15 -0400, Tom Lane wrote: >> ... What I did instead was to shove >> that test case and some related ones into a new plpgsql test file, >> src/pl/plpgsql/src/sql/plpgsql_trap.sql, so that it's not part of the >> core regression tests at all. (We've talked before about moving >> chunks of plpgsql.sql into the plpgsql module, so this is sort of a >> down payment on that.) Now, if you think about the time to do >> check-world rather than just the core regression tests, this isn't >> obviously a win, and in fact it might be a loss because the plpgsql >> tests run serially not in parallel with anything else. > Hm, can't we "just" parallelize the plpgsql schedule instead? If somebody wants to work on that, I won't stand in the way, but it seems like material for a different patch. >> Thoughts? Anyone object to making these sorts of changes >> post-feature-freeze? > Hm. There's some advantage to doing so, because it won't break any large > pending changes. But it's also possible that it'll destabilize the > buildfarm some. In personal capacity I'm like +0.5. My thought was that there is (hopefully) going to be a lot of testing going on over the next few months, so making that faster would be a useful activity. regards, tom lane