Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pJgZi-0005tG-R9
	for pgsql-hackers@arkaria.postgresql.org; Sun, 22 Jan 2023 20:04:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pJgZh-0005WS-Gp
	for pgsql-hackers@arkaria.postgresql.org; Sun, 22 Jan 2023 20:04:21 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pJgZh-0005US-6E
	for pgsql-hackers@lists.postgresql.org; Sun, 22 Jan 2023 20:04:21 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pJgZe-0001XT-Sq
	for pgsql-hackers@postgresql.org; Sun, 22 Jan 2023 20:04:20 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30MK4EZH1413124;
	Sun, 22 Jan 2023 15:04:15 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Isaac Morland <isaac.morland@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Pavel Stehule <pavel.stehule@gmail.com>,
        Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Subject: Re: Remove source code display from \df+?
In-reply-to: <CAMsGm5f6Cyq3sbjyb2hi1MNjadR=Q-XYr-k_06OmE0vYCF-C8g@mail.gmail.com>
References: <CAMsGm5dgogOZ5yNc9BsnFM0n4FuykZREmro9f9gvOBWD_D1-2w@mail.gmail.com> <20230122191549.5b35ulimlvz42y7l@alvherre.pgsql> <CAMsGm5f6Cyq3sbjyb2hi1MNjadR=Q-XYr-k_06OmE0vYCF-C8g@mail.gmail.com>
Comments: In-reply-to Isaac Morland <isaac.morland@gmail.com>
	message dated "Sun, 22 Jan 2023 14:53:48 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1413122.1674417854.1@sss.pgh.pa.us>
Date: Sun, 22 Jan 2023 15:04:14 -0500
Message-ID: <1413123.1674417854@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/1413123.1674417854%40sss.pgh.pa.us>
Precedence: bulk

Isaac Morland <isaac.morland@gmail.com> writes:
> On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera <alvherre@alvh.no-ip.org>
> wrote:
>> This one would fail the sanity check that all roles created by
>> regression tests need to have names that start with "regress_".

> Thanks for the correction. Now I feel like I've skipped some of the
> readings!
> Updated patch attached. Informally, I am adopting the regress_* policy for
> all object types.

That's excessive.  The policy Alvaro mentions applies to globally-visible
object names (i.e., database, role, and tablespace names), and it's there
to try to ensure that doing "make installcheck" against a live
installation won't clobber any non-test-created objects.  There's no point
in having such a policy within a test database --- its most likely effect
there would be to increase the risk that different test scripts step on
each others' toes.  If you feel a need for a name prefix for non-global
objects, use something based on the name of your test script.

			regards, tom lane