From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: joseph.ayers@crunchydata.com, Michael Paquier <michael@paquier.xyz>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: Removing support for COPY FROM STDIN in protocol version 2
In-reply-to: <b1146fdb-8d08-2bf2-cda2-638b63d4a007@iki.fi>
References: <20210203160958.GA2341@alvherre.pgsql>
 <3921698.1612369777@sss.pgh.pa.us> <YBuaJXBJOPRVCA5I@paquier.xyz>
 <6d6dcead-71fa-d9f6-4aaa-41104af0f27c@iki.fi>
 <1318732.1614814378@sss.pgh.pa.us>
 <8a174f9b-59e4-e231-5b66-1f01b314882a@iki.fi>
 <1410154.1614888292@sss.pgh.pa.us>
 <b1146fdb-8d08-2bf2-cda2-638b63d4a007@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Thu, 04 Mar 2021 22:55:54 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1413582.1614893735.1@sss.pgh.pa.us>
Date: Thu, 04 Mar 2021 16:35:35 -0500
Message-ID: <1413583.1614893735@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1413583.1614893735%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Joseph, any chance we could see a backtrace or some other details from 
> those crashes?

+1

> 'drongo' just reported linker errors:
> postgres.def : error LNK2001: unresolved external symbol 
> GetOldFunctionMessage 
> [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj]
> postgres.def : error LNK2001: unresolved external symbol errfunction 
> [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj]
> postgres.def : error LNK2001: unresolved external symbol pq_getstring 
> [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj]
> postgres.def : error LNK2001: unresolved external symbol pq_putbytes 
> [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj]
> Release/postgres/postgres.lib : fatal error LNK1120: 4 unresolved 
> externals [c:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj]
> Done Building Project 
> "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\postgres.vcxproj" (default 
> targets) -- FAILED.

As far as that goes, I think suspicion has to fall on this:

  Not re-generating POSTGRES.DEF, file already exists.

which gendef.pl prints if it thinks the def file is newer than
all the inputs.  So either drongo had some kind of clock skew
issue, or that bit of logic in gendef.pl has some unobvious bug.

(I say "had" because I see the next run went fine.)

			regards, tom lane