Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obOsV-0000Ld-RU for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Sep 2022 16:16:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1obOsU-0001rC-Nf for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Sep 2022 16:16:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obOsU-0001r3-Ew for pgsql-hackers@lists.postgresql.org; Thu, 22 Sep 2022 16:16:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obOsN-00035d-Ii for pgsql-hackers@lists.postgresql.org; Thu, 22 Sep 2022 16:16:42 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28MGGU8u1415327; Thu, 22 Sep 2022 12:16:30 -0400 From: Tom Lane To: Andres Freund cc: Peter Eisentraut , pgsql-hackers@lists.postgresql.org Subject: Re: Extending outfuncs support to utility statements In-reply-to: <20220922153257.r5wj74prdqrucnov@awork3.anarazel.de> References: <4159834.1657405226@sss.pgh.pa.us> <9b197806-17ee-acba-0e70-01263aa46e79@enterprisedb.com> <1972439.1657665506@sss.pgh.pa.us> <2e7adbce-2ff5-866e-8753-9969b0ce332b@enterprisedb.com> <20220922153257.r5wj74prdqrucnov@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 22 Sep 2022 08:32:57 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1415325.1663863390.1@sss.pgh.pa.us> Date: Thu, 22 Sep 2022 12:16:30 -0400 Message-ID: <1415326.1663863390@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-08-24 17:25:31 +0200, Peter Eisentraut wrote: >> Here are patches for that. > These patches have been failing since they were posted, afaict: > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3848 > I assume that's known? I think this is the issue Peter mentioned about needing to distinguish between empty strings and NULL strings. We're going to need to rethink the behavior of pg_strtok() a bit to fix that. regards, tom lane