Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1waQ05-001ms6-0G
	for pgsql-hackers@arkaria.postgresql.org;
	Fri, 19 Jun 2026 03:34:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1waQ02-00EqbG-0P
	for pgsql-hackers@arkaria.postgresql.org;
	Fri, 19 Jun 2026 03:34:34 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1waQ01-00Eqb8-2j
	for pgsql-hackers@lists.postgresql.org;
	Fri, 19 Jun 2026 03:34:33 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1waPzz-00000001CxN-2Lxs
	for pgsql-hackers@lists.postgresql.org;
	Fri, 19 Jun 2026 03:34:33 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 65J3YRPC1422593;
	Thu, 18 Jun 2026 23:34:27 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Chao Li <li.evan.chao@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
        Andres Freund <andres@anarazel.de>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns
In-reply-to: 
 <CAApHDvqCuoyx8fPKoH6bbhLxhgfPg62f3aqc5FFhC_dd_8fNaA@mail.gmail.com>
References: <A4BC563C-0CA3-4EF3-952A-EA41F9E5BF1E@gmail.com>
 <CAApHDvoQKY8zHb1LZBuYZBRszi0qVmTaV_zFup=A9xqRpJWMRQ@mail.gmail.com>
 <pse3eru75b5skbvc7jjrf7origavqojc6nqtwdrr7z6sjkyxfo@siklvj643v4f>
 <BB69B882-5401-45CE-919E-8A78511EDABC@gmail.com>
 <CAApHDvogTSD_G1nkJqOvO3gZFACQUCbKg6U7yBB48r5RMaR7-Q@mail.gmail.com>
 <CAApHDvrJBXEhet4=Es_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@mail.gmail.com>
 <1151393.1781734980@sss.pgh.pa.us> <1174236.1781736349@sss.pgh.pa.us>
 <CAApHDvpE1Jx=NrwUCihrfP+Dmkfn6kUkpCZYC10Yo+wkMu3ssQ@mail.gmail.com>
 <CAApHDvq6FaC441C=G4Q9fNZQ-OKmaeW8yP0YjHpjyjBeWhj3+g@mail.gmail.com>
 <2A622929-A45C-4370-943A-BC76FF4CC433@gmail.com>
 <CAApHDvqrPnvJcTCT6631OHwMbXmP66uOmhrc7-0KG_8kwJ3wPA@mail.gmail.com>
 <03C47613-5C89-4E69-BB72-3B2912BDDDA8@gmail.com>
 <CAApHDvp4nvyt0mMo3qxGLohR2beN3AtzKpyKm98gAO+cvWJ7Mg@mail.gmail.com>
 <96A79F87-ACDF-479F-B69D-0CACB7085C97@gmail.com>
 <CAApHDvqCuoyx8fPKoH6bbhLxhgfPg62f3aqc5FFhC_dd_8fNaA@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Fri, 19 Jun 2026 15:30:11 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1422591.1781840067.1@sss.pgh.pa.us>
Date: Thu, 18 Jun 2026 23:34:27 -0400
Message-ID: <1422592.1781840067@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1422592.1781840067%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> For the v18 version, I included the tests added by 1f7dfe8c8 in the
> same commit. I did it that way so as not to briefly introduce a test
> that would fail into REL_18_STABLE.

+1, doing it the other way would create a landmine for git-bisect
testing.

			regards, tom lane