Message-ID: <1426155421.2535.11.camel@redhat.com>
Subject: shebang for tcl postgresql modules
From: Jozef Mlich <jmlich@redhat.com>
To: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: Thu, 12 Mar 2015 11:17:01 +0100
Content-Type: multipart/mixed; boundary="=-mm6fA1+LTxSmSKSkBW5m"
Mime-Version: 1.0
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--=-mm6fA1+LTxSmSKSkBW5m
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Dear hackers,

I would like to ask you if is there any reason to pretend tcl scripts
are shell scripts?

I am speaking namely about these files

http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_delmod.in;hb=HEAD
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_listmod.in;hb=HEAD
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_loadmod.in;hb=HEAD


Here is the part of code I am speaking about:

#! /bin/sh
# Start tclsh \
exec @TCLSH@ "$0" "$@"

instead of
#! /usr/bin/tclsh

or 
#! @TCLSH@

I am asking because our test suite is triggering errors on this [1]. In
this case, it seems easier to modify code rather then test suite. Please
apply attached patch if there is no particular reason for use
of /bin/sh.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1199464


-- 
Jozef Mlich <jmlich@redhat.com>
Associate Software Engineer - EMEA ENG Developer Experience
Mobile: +420 604 217 719
http://cz.redhat.com/
Red Hat, Inc.

--=-mm6fA1+LTxSmSKSkBW5m
Content-Disposition: attachment; filename="tcl-shebang.patch"
Content-Type: text/x-patch; name="tcl-shebang.patch"; charset="UTF-8"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9wbC90Y2wvbW9kdWxlcy9wbHRjbF9kZWxtb2Qu
aW4gYi9zcmMvcGwvdGNsL21vZHVsZXMvcGx0Y2xfZGVsbW9kLmluCmluZGV4
IGRhYTRmYWMuLjZiOGNkYTQgMTAwNjQ0Ci0tLSBhL3NyYy9wbC90Y2wvbW9k
dWxlcy9wbHRjbF9kZWxtb2QuaW4KKysrIGIvc3JjL3BsL3RjbC9tb2R1bGVz
L3BsdGNsX2RlbG1vZC5pbgpAQCAtMSw4ICsxLDYgQEAKLSMhIC9iaW4vc2gK
KyMhIEBUQ0xTSEAKICMgc3JjL3BsL3RjbC9tb2R1bGVzL3BsdGNsX2RlbG1v
ZC5pbgogIwotIyBTdGFydCB0Y2xzaCBcCi1leGVjIEBUQ0xTSEAgIiQwIiAi
JEAiCiAKICMKICMgQ29kZSBzdGlsbCBoYXMgdG8gYmUgZG9jdW1lbnRlZApk
aWZmIC0tZ2l0IGEvc3JjL3BsL3RjbC9tb2R1bGVzL3BsdGNsX2xpc3Rtb2Qu
aW4gYi9zcmMvcGwvdGNsL21vZHVsZXMvcGx0Y2xfbGlzdG1vZC5pbgppbmRl
eCA3ZDkzMGZmLi5jM2VhMTM4IDEwMDY0NAotLS0gYS9zcmMvcGwvdGNsL21v
ZHVsZXMvcGx0Y2xfbGlzdG1vZC5pbgorKysgYi9zcmMvcGwvdGNsL21vZHVs
ZXMvcGx0Y2xfbGlzdG1vZC5pbgpAQCAtMSw4ICsxLDYgQEAKLSMhIC9iaW4v
c2gKKyMhIEBUQ0xTSEAKICMgc3JjL3BsL3RjbC9tb2R1bGVzL3BsdGNsX2xp
c3Rtb2QuaW4KICMKLSMgU3RhcnQgdGNsc2ggXAotZXhlYyBAVENMU0hAICIk
MCIgIiRAIgogCiAjCiAjIENvZGUgc3RpbGwgaGFzIHRvIGJlIGRvY3VtZW50
ZWQKZGlmZiAtLWdpdCBhL3NyYy9wbC90Y2wvbW9kdWxlcy9wbHRjbF9sb2Fk
bW9kLmluIGIvc3JjL3BsL3RjbC9tb2R1bGVzL3BsdGNsX2xvYWRtb2QuaW4K
aW5kZXggNjQ1YzZiYi4uMDZiNDU5YiAxMDA2NDQKLS0tIGEvc3JjL3BsL3Rj
bC9tb2R1bGVzL3BsdGNsX2xvYWRtb2QuaW4KKysrIGIvc3JjL3BsL3RjbC9t
b2R1bGVzL3BsdGNsX2xvYWRtb2QuaW4KQEAgLTEsNiArMSw1IEBACi0jISAv
YmluL3NoCi0jIFN0YXJ0IHRjbHNoIFwKLWV4ZWMgQFRDTFNIQCAiJDAiICIk
QCIKKyMhIEBUQ0xTSEAKKyMKIAogIwogIyBDb2RlIHN0aWxsIGhhcyB0byBi
ZSBkb2N1bWVudGVkCg==

--=-mm6fA1+LTxSmSKSkBW5m
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--=-mm6fA1+LTxSmSKSkBW5m--