From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
        Stephen Frost <sfrost@snowman.net>,
        Magnus Hagander <magnus@hagander.net>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] remove deprecated v8.2 containment operators
In-reply-to: <20210202140557.GT7450@telsasoft.com>
References: <20201027032511.GF9241@telsasoft.com>
 <155ecfd8-7ac6-1875-5090-d79a586a8847@enterprisedb.com>
 <235561.1605220100@sss.pgh.pa.us>
 <CABUevEyLtOAPtY3MYap0b6H23WmsrGHmFN6On6v7CDi14FORDw@mail.gmail.com>
 <20201113150343.GT16415@tamriel.snowman.net>
 <20201116205516.GM14024@telsasoft.com>
 <ce7bcfe6-6505-3b36-49be-9e340053371f@postgrespro.ru>
 <20201130190611.GY24052@telsasoft.com> <1277206.1606763350@sss.pgh.pa.us>
 <20210202140557.GT7450@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Tue, 02 Feb 2021 08:05:58 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1432460.1614909519.1@sss.pgh.pa.us>
Date: Thu, 04 Mar 2021 20:58:39 -0500
Message-ID: <1432461.1614909519@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1432461.1614909519%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> [ 0001-remove-deprecated-v8.2-containment-operators.patch ]

I'm confused by why this patch is only dropping the operators'
opclass-membership links.  Don't we want to actually DROP OPERATOR
too?

Also, the patch seems to be trying to resurrect hstore--1.0--1.1.sql,
which I do not see the point of.  It was removed because no modern
server will even think it's valid syntax, and that situation has
not changed.

			regards, tom lane