From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Craig Ringer <craig.ringer@enterprisedb.com>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: 011_crash_recovery.pl intermittently fails
In-reply-to: 
 <CAH2-Wz=w2yUTvT75gedn8uL_UX=6fPVAyNMGZ7YMLerSMARo0g@mail.gmail.com>
References: <20210305.115011.558061052471425531.horikyota.ntt@gmail.com>
 <1436448.1614915141@sss.pgh.pa.us>
 <CAH2-Wz=w2yUTvT75gedn8uL_UX=6fPVAyNMGZ7YMLerSMARo0g@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Thu, 04 Mar 2021 19:41:06 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1437507.1614916929.1@sss.pgh.pa.us>
Date: Thu, 04 Mar 2021 23:02:09 -0500
Message-ID: <1437508.1614916929@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1437508.1614916929%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Thu, Mar 4, 2021 at 7:32 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmmm ... what environment is that?  This test script hasn't changed
>> meaningfully in several years, and we have not seen any real issues
>> with it up to now.

> Did you see this recent thread?
> https://postgr.es/m/20210208215206.mqmrnpkaqrdtm7fj@alap3.anarazel.de

Hadn't paid much attention at the time, but yeah, it looks like Andres
tripped over some variant of this.

I'd be kind of inclined to remove this test script altogether, on the
grounds that it's wasting cycles on a function that doesn't really
do what is claimed (and we should remove the documentation claim, too).

Having said that, it's still true that this test has been stable in
the buildfarm.  Andres explained what he had to perturb to make it
fail, so I'm still interested in what Horiguchi-san did to break it.

			regards, tom lane