From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nikolay Shaplov <dhyan@nataraj.su>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Build problem with square brackets in build path
In-reply-to: <4793552.atqmVPU5g4@thinkpad-pgpro>
References: <4793552.atqmVPU5g4@thinkpad-pgpro>
Comments: In-reply-to Nikolay Shaplov <dhyan@nataraj.su>
	message dated "Fri, 28 Apr 2023 14:09:59 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1439277.1682705197.1@sss.pgh.pa.us>
Date: Fri, 28 Apr 2023 14:06:37 -0400
Message-ID: <1439278.1682705197@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1439278.1682705197%40sss.pgh.pa.us>
Precedence: bulk

Nikolay Shaplov <dhyan@nataraj.su> writes:
> If you do

> mkdir [source]
> git clone git://git.postgresql.org/git/postgresql.git [source]
> mkdir build; cd build
> ../\[source\]/configure 
> make

> you will get

> make[1]: *** No rule to make target 'generated-headers'.  Stop.

> If there are no "[]" in the path to the source, everything is OK.

It's generally quite unwise to use shell meta-characters in
file or directory names.  I give you one example:

$ ls ../[source]
COPYRIGHT               README.git              contrib/
GNUmakefile.in          aclocal.m4              doc/
HISTORY                 config/                 meson.build
Makefile                configure*              meson_options.txt
README                  configure.ac            src/
$ ls ../[source]/*.ac
ls: ../[source]/*.ac: No such file or directory

This is expected behavior (I leave it as an exercise for the
student to figure out why).

While it might be possible to make the Postgres build scripts
proof against funny characters in the build paths, the effort
required would be far out of proportion to the value.  Not least
because manual operations in such a file tree would misbehave
often enough to convince you to change, even if the scripts were
all water-tight.

			regards, tom lane