From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kirill Reshke <reshkekirill@gmail.com>
cc: jian he <jian.universality@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt
In-reply-to: 
 <CALdSSPiZtCRJhe=KdPKEmeYNZQe_yhQKVn3QCsfrCiNdOCTP0A@mail.gmail.com>
References: 
 <CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com>
 <CALdSSPiZtCRJhe=KdPKEmeYNZQe_yhQKVn3QCsfrCiNdOCTP0A@mail.gmail.com>
Comments: In-reply-to Kirill Reshke <reshkekirill@gmail.com>
	message dated "Thu, 21 Aug 2025 20:20:52 +0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1440196.1755790079.1@sss.pgh.pa.us>
Date: Thu, 21 Aug 2025 11:27:59 -0400
Message-ID: <1440197.1755790079@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1440197.1755790079%40sss.pgh.pa.us>
Precedence: bulk

Kirill Reshke <reshkekirill@gmail.com> writes:
> On Thu, 21 Aug 2025 at 17:00, jian he <jian.universality@gmail.com> wrote:
>> RangeVar   *rel = (RangeVar *) linitial(stmt->relations);
>> if (!IsA(rel, RangeVar))

> These two lines are weird. Looks like  linitial(stmt->relations)
> should be assigned to variable with type Node* first?

We take that sort of shortcut in many places.  If there's not any need
for the code to deal with more than one node type, an extra variable
that's used just for the IsA test seems like a lot of notational
overhead.

			regards, tom lane