Date: Mon, 28 Sep 2015 07:40:54 -0700 (MST)
From: zhangjinyu <beijing_pg@163.com>
To: pgsql-hackers@postgresql.org
Message-ID: <1443451254826-5867647.post@n5.nabble.com>
In-Reply-To: <20150927175608.GM295765@alvherre.pgsql>
References: <495deb78.4186.1500dacaa63.Coremail.beijing_pg@163.com>
 <20150927175608.GM295765@alvherre.pgsql>
Subject: Re: Patch: Optimize memory allocation in function 'bringetbitmap'
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Yes,  I forgot disable-c-assert last test.  
The following show the test result when disable-c-assert.
I think it's still worthwhile.
*After optimize code (warm run)*
postgres=# select count(*) from lineitem where l_orderkey=1;
 count 
-------
     6
(1 row)

Time: 327.143 ms
*Before optimizing code (warm run)*
postgres=# select count(*) from lineitem where l_orderkey=1;
 count 
-------
     6
(1 row)

Time: 404.323 ms

>>>>However I wonder if it would be simpler to have the dtup structure have
>>>>the pointers, so that you can pass it as NULL in the first call and then
>>>>followup calls reuse the one allocated in the first call.
Jinyu:  the memory is allocated from perRangeCxt  and perRangeCxt will be
reset in loop,
so this way don't work. 

Jinyu Zhang


--
View this message in context: http://postgresql.nabble.com/Patch-Optimize-memory-allocation-in-function-bringetbitmap-tp5867537p5867647.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers