From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
cc: "David G. Johnston" <david.g.johnston@gmail.com>,
        =?utf-8?B?RmFicsOtemlv?= Mello <fabriziomello@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add important info about ANALYZE after create Functional Index
In-reply-to: <20201028191201.wh5ldvhsiqy2vknu@development>
References: 
 <CAFcNs+qpFPmiHd1oTXvcPdvAHicJDA9qBUSujgAhUMJyUMb+SA@mail.gmail.com>
 <CAKFQuwb9GFe4oM3k9bsn7GOk5_jfow-9SpWocAG4xAYVp9nLjg@mail.gmail.com>
 <20201028185538.fzux2lhim472h46o@development>
 <CAKFQuwYGj-P3un2rGbj8Yc8oUohf_kUkDCnO5ap57bO85e56dQ@mail.gmail.com>
 <20201028191201.wh5ldvhsiqy2vknu@development>
Comments: In-reply-to Tomas Vondra <tomas.vondra@2ndquadrant.com>
	message dated "Wed, 28 Oct 2020 20:12:01 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1443541.1603912732.1@sss.pgh.pa.us>
Date: Wed, 28 Oct 2020 15:18:52 -0400
Message-ID: <1443542.1603912732@sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> On Wed, Oct 28, 2020 at 12:00:54PM -0700, David G. Johnston wrote:
>> Given how simple the manual workaround is not having it be manual seems
>> like it would be safe and straight-forward to implement.

> Maybe, but I wouldn't be surprised if it was actually a bit trickier in
> practice, particularly for the CONCURRENTLY case. But I haven't tried.

> Anyway, I think there's an agreement it'd be valuable to do this after
> CREATE INDEX in the future, so if someone wants to implement it that'd
> be great. We can consider backpatching only once we have an actual patch
> anyway.

Just to be clear, I'm entirely *not* on board with that.  IMV it's
intentional that we do not force auto-analyze activity after CREATE
INDEX or CREATE STATISTICS.  If we change that, people will want a
way to opt out of it, and then your "simple" patch isn't so simple
anymore.  (Not that it was simple anyway.  What if the CREATE is
inside a transaction block, for instance?  There's no use in
kicking autovacuum before commit.)

			regards, tom lane