From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Thomas Munro <thomas.munro@gmail.com>,
        Fujii Masao <fujii@postgresql.org>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Weird failure with latches in curculio on v15
In-reply-to: <Y9sam108o4mxZFiS@paquier.xyz>
References: <Y9nGDSgIm83FHcad@paquier.xyz>
 <20230201021206.wobi3dsnnuany3yq@alap3.anarazel.de>
 <CA+hUKGKf9Bgik=g1yPQ-crSuuziyFsScnbauG50O5328TKV1rA@mail.gmail.com>
 <20230201105514.rsjl4bnhb65giyvo@alap3.anarazel.de>
 <1369666.1675264346@sss.pgh.pa.us>
 <20230201165801.33ydbxvjdbomjqa7@alap3.anarazel.de>
 <20230201175806.GA3199959@nathanxps13> <20230201223555.GA3721373@nathanxps13>
 <Y9sam108o4mxZFiS@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 02 Feb 2023 11:06:19 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1449632.1675305284.1@sss.pgh.pa.us>
Date: Wed, 01 Feb 2023 21:34:44 -0500
Message-ID: <1449633.1675305284@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1449633.1675305284%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Hmm.  Isn't that something that we should also document in startup.c
> where both routines are defined?  If we begin to use
> PreRestoreCommand() and PostRestoreCommand() in more code paths in the
> future, that could be again an issue.

I was vaguely wondering about removing both of those functions
in favor of an integrated function that does a system() call
with those things before and after it.

			regards, tom lane