Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j2OY3-00036H-Hr for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Feb 2020 00:09:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j2OY2-0003yD-6C for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Feb 2020 00:09:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j2OY1-0003u0-TI for pgsql-hackers@lists.postgresql.org; Fri, 14 Feb 2020 00:09:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2OXr-0002x2-HE for pgsql-hackers@lists.postgresql.org; Fri, 14 Feb 2020 00:09:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01E09IKQ014516; Thu, 13 Feb 2020 19:09:18 -0500 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org Subject: Re: Marking some contrib modules as trusted extensions In-reply-to: <13921.1581638230@sss.pgh.pa.us> References: <32315.1580326876@sss.pgh.pa.us> <20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de> <13921.1581638230@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Thu, 13 Feb 2020 18:57:10 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14513.1581638958.1@sss.pgh.pa.us> Date: Thu, 13 Feb 2020 19:09:18 -0500 Message-ID: <14514.1581638958@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > Andres Freund writes: >> It seems to me that FROM UNPACKAGED shouldn't support trusted. > Hmm, seems like a reasonable idea, but I'm not quite sure how to mechanize > it given that "unpackaged" isn't magic in any way so far as extension.c > is concerned. Maybe we could decide that the time for supporting easy > updates from pre-9.1 is past, and just remove all the unpackaged-to-XXX > scripts? Maybe even remove the "FROM version" option altogether. [ thinks some more... ] A less invasive idea would be to insist that you be superuser to use the FROM option. But I'm thinking that the unpackaged-to-XXX scripts are pretty much dead letters anymore. Has anyone even tested them in years? How much longer do we want to be on the hook to fix them? regards, tom lane