Message-ID: <1457544102.24545.79.camel@2ndquadrant.com>
Subject: Re: multivariate statistics v14
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers
	 <pgsql-hackers@postgresql.org>
Date: Wed, 09 Mar 2016 18:21:42 +0100
In-Reply-To: 
 <CAMkU=1wDq9Gm+mg0YYY_JVw6kxYD6=n_FG-YPLrOFyWVnBhy9Q@mail.gmail.com>
References: <20160309122245.GA958049@alvherre.pgsql>
	 <1457535779.24545.71.camel@2ndquadrant.com>
	 <CAMkU=1wDq9Gm+mg0YYY_JVw6kxYD6=n_FG-YPLrOFyWVnBhy9Q@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-fCiZgilGOBbGUuNGBTxq"
Mime-Version: 1.0
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--=-fCiZgilGOBbGUuNGBTxq
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi,

On Wed, 2016-03-09 at 08:45 -0800, Jeff Janes wrote:
> On Wed, Mar 9, 2016 at 7:02 AM, Tomas Vondra
> <tomas.vondra@2ndquadrant.com> wrote:
> > Hi,
> >
> > thanks for the feedback. Attached is v14 of the patch series, fixing
> > most of the points you've raised.
> 
> 
> Hi Tomas,
> 
> Applied to aa09cd242fa7e3a694a31f, I still get the seg faults in make
> check if I configure without --enable-cassert.

Ah, after disabling asserts I can reproduce it too. And the reason why
it fails is quite simple - clauselist_selectivity modifies the original
list of clauses, which then confuses cost_qual_eval.

Can you try if the attached patch fixes the issue? I'll need to rework a
bit more of the code, but let's see if this fixes the issue on your
machine too.

> With --enable-cassert, it passes the regression test.

I wonder how can it work with casserts and fail without them. That's
kinda exactly the opposite to what I'd expect ...

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--=-fCiZgilGOBbGUuNGBTxq
Content-Disposition: attachment; filename="mvstats-segfault-fix.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name="mvstats-segfault-fix.patch"; charset="UTF-8"

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2NsYXVz
ZXNlbC5jIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BhdGgvY2xhdXNlc2Vs
LmMKaW5kZXggMjU0MGRhOS4uZGRmZGMzYiAxMDA2NDQKLS0tIGEvc3JjL2Jh
Y2tlbmQvb3B0aW1pemVyL3BhdGgvY2xhdXNlc2VsLmMKKysrIGIvc3JjL2Jh
Y2tlbmQvb3B0aW1pemVyL3BhdGgvY2xhdXNlc2VsLmMKQEAgLTI3OSw2ICsy
NzksMTAgQEAgY2xhdXNlbGlzdF9zZWxlY3Rpdml0eShQbGFubmVySW5mbyAq
cm9vdCwKIAkJTGlzdCAqc29sdXRpb24gPSBjaG9vc2VfbXZfc3RhdGlzdGlj
cyhyb290LCByZWxpZCwgc3RhdHMsCiAJCQkJCQkJCQkJCSAgY2xhdXNlcywg
Y29uZGl0aW9ucyk7CiAKKwkJLyogRklYTUUgd2UgbXVzdCBub3Qgc2NyaWJi
bGUgb3ZlciB0aGUgb3JpZ2luYWwgbGlzdCAqLworCQlpZiAoc29sdXRpb24p
CisJCQljbGF1c2VzID0gbGlzdF9jb3B5KGNsYXVzZXMpOworCiAJCS8qCiAJ
CSAqIFdlIGhhdmUgYSBnb29kIHNvbHV0aW9uLCB3aGljaCBpcyBtZXJlbHkg
YSBsaXN0IG9mIHN0YXRpc3RpY3MgdGhhdAogCQkgKiB3ZSBuZWVkIHRvIGFw
cGx5LiBXZSdsbCBhcHBseSB0aGUgc3RhdGlzdGljcyBvbmUgYnkgb25lIChp
biB0aGUgb3JkZXIK

--=-fCiZgilGOBbGUuNGBTxq
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--=-fCiZgilGOBbGUuNGBTxq--