From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Do we still need gen_node_support.pl's nodetag ABI stability check?
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1458882.1776143073.1@sss.pgh.pa.us>
Date: Tue, 14 Apr 2026 01:04:33 -0400
Message-ID: <1458883.1776143073@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1458883.1776143073%40sss.pgh.pa.us>
Precedence: bulk

We're still a couple months away from cutting the REL_19_STABLE
branch, but I was contemplating that just now, and it occurred to me
to wonder whether we still need gen_node_support.pl's single-purpose
ABI check (cf commit eea9fa9b2) now that we have buildfarm animals
running general-purpose ABI stability checks.

On the one hand, there's much to be said for belt-and-suspenders-too
safety checks.  On the other hand, updating gen_node_support.pl is
an extra manual step while creating a branch, so it's easy to forget
or get wrong.  It's also not very clear why this particular sort
of ABI break in a stable branch is any worse than other hazards.

I'm not really set either way, but my first thought is to drop
the special mechanism.

			regards, tom lane