From: Antonin Houska <ah@cybertec.at>
To: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: 
 <CADzfLwWFbXVN-QrKaVXvW96eYQD1AiRVCYd99nX7EQFG3q_yfg@mail.gmail.com>
References: <202510301734.pj4uds3mqxx4@alvherre.pgsql>
 <116433.1764870207@localhost>
 <CADzfLwWFbXVN-QrKaVXvW96eYQD1AiRVCYd99nX7EQFG3q_yfg@mail.gmail.com>
Comments: In-reply-to Mihail Nikalayeu <mihailnikalayeu@gmail.com>
   message dated "Fri, 05 Dec 2025 01:03:00 +0100."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Mon, 08 Dec 2025 08:35:53 +0100
Message-ID: <14628.1765179353@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/14628.1765179353%40localhost>
Precedence: bulk

Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:

> On Thu, Dec 4, 2025 at 6:43=E2=80=AFPM Antonin Houska <ah@cybertec.at> wr=
ote:
> > v26 attached here. It's been rebased and reflects most of the feedback.
>=20
> Some comments on 0001-0002:
> 1)
>=20
> > cluster_rel(stmt->command, rel, indexOid, params);
> cluster_rel closes relation, and after it is dereferenced a few lines aft=
er.
> Technically it may be correct, but feels a little bit strange.

ok, will be fixed in the next version (supposedly later today).

> 2)
>=20
> > if (vacopts->mode =3D=3D MODE_VACUUM)
> I think for better compatibility it is better to handle new value in
> if - (vacopts->mode =3D=3D MODE_REPACK) to keep old cases unchanged

I suppose you mean vacuuming.c. We're considering removal of pg_repackdb fr=
om
the patchset, so let's decide on this later.

> 3)
>=20
> > case T_RepackStmt:
> >    tag =3D CMDTAG_REPACK;
> >    break;
>=20
> should we use instead:
>=20
> case T_RepackStmt:
>     if (((RepackStmt *) parsetree)->command =3D=3D REPACK_COMMAND_CLUSTER)
>        tag =3D CMDTAG_CLUSTER;
>     else
>        tag =3D CMDTAG_REPACK;
>     break;
>=20
> or delete CMDTAG_CLUSTER - since it not used anymore

LGTM, will include it in the next version.

> 4)
> "has been superceded by"
> typo

ok. (This may also be removed, as it's specific to pg_repackdb.)

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com