From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Joel Jacobson" <joel@compiler.org>
cc: "Arseniy Mukhin" <arseniy.mukhin.dev@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
In-reply-to: <e2e857de-f0bc-4c56-99ba-5d34d41dcdb0@app.fastmail.com>
References: <9835b0a4-9121-47ac-9c44-427b8b1a7f1b@app.fastmail.com>
 <CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
 <e46886ff-4a49-47fb-a76f-3b2f012f1948@app.fastmail.com>
 <CAE7r3MLi9MRfysi+0AcEBzO-tR1PCDr40KT7E+Qgpa9WZHZhmg@mail.gmail.com>
 <e2e857de-f0bc-4c56-99ba-5d34d41dcdb0@app.fastmail.com>
Comments: In-reply-to "Joel Jacobson" <joel@compiler.org>
	message dated "Wed, 20 May 2026 21:49:51 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14716.1779810009.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 26 May 2026 11:40:09 -0400
Message-ID: <14717.1779810009@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/14717.1779810009%40sss.pgh.pa.us>
Precedence: bulk

"Joel Jacobson" <joel@compiler.org> writes:
> Ohh, right, thanks for spotting. New version attached, 0001 and 0002 ide=
ntical,
> and 0003 now only contain the fix.

I agree with this fix, but it seems to me that it changes the meaning
of the ListenerEntry.listening flag in a rather fundamental way.
I'm tempted to rename that flag to "committed" or something like that.

(Both "listening" and "committed" appear in dozens of places in this
file that are not references to this flag, so TBH I'd rather use a
flag name that is not either of those words.  But I can't think of
a better name.)

Also, while the proposed test cases are good for showing that there's
a bug here, I'm disinclined to commit them.  I do not think there is
value in them proportionate to the cost of two new isolation-test
instances.

			regards, tom lane