Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g7Ppn-00017s-As for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Oct 2018 18:55:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g7Ppl-0006zU-OQ for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Oct 2018 18:55:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g7Ppl-0006zN-Dj for pgsql-hackers@lists.postgresql.org; Tue, 02 Oct 2018 18:55:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g7Ppi-0002va-P5 for pgsql-hackers@lists.postgresql.org; Tue, 02 Oct 2018 18:55:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w92ItTQI001473; Tue, 2 Oct 2018 14:55:29 -0400 From: Tom Lane To: Amit Kapila cc: Thomas Munro , PostgreSQL Hackers , hlinnaka Subject: Re: SerializeParamList vs machines with strict alignment In-reply-to: References: <11629.1536550032@sss.pgh.pa.us> <8352.1536586500@sss.pgh.pa.us> <27748.1538425312@sss.pgh.pa.us> <28627.1538426947@sss.pgh.pa.us> <4694.1538438514@sss.pgh.pa.us> <8134.1538444333@sss.pgh.pa.us> <12777.1538452350@sss.pgh.pa.us> <13340.1538453286@sss.pgh.pa.us> <14314.1538455069@sss.pgh.pa.us> Comments: In-reply-to Amit Kapila message dated "Tue, 02 Oct 2018 19:48:09 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1471.1538506529.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 02 Oct 2018 14:55:29 -0400 Message-ID: <1472.1538506529@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Amit Kapila writes: >> Okay, I have pushed the test case patch on HEAD. Attached is the >> code-fix patch, let's wait for a day so that we have all the results >> which can help us to discuss the merits of this patch. > By now, the added test has failed on gharial [1] with below log on the s= erver: Yeah, gharial and anole both don't like this, which is interesting but not really surprising, considering that IA64 is in some part an HPPA follow-on architecture. What I find more interesting is that both of the live Sparc critters are happy --- so despite Thomas' statements upthread, they're coping with unaligned accesses. Maybe you should have back-patched the test to older branches so we could see what castoroides and protosciurus would do. But it's probably not worth additional delay. regards, tom lane