From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Tels <nospam-pg-abuse@bloodgate.com>, Robert Haas <robertmhaas@gmail.com>,
        Joe Conway <mail@joeconway.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Upgrading postmaster's log messages about bind/listen errors
In-reply-to: <20170310162722.GG9812@tamriel.snowman.net>
References: <9564.1489091245@sss.pgh.pa.us>
 <e3a1715d-dd25-d9bb-4a28-6839c242a2f7@joeconway.com>
 <CA+TgmoYpQiZMPHfQX8x8P+RqEq0XQBSb32QHTZ8dDwU+aP3qzg@mail.gmail.com>
 <19479.1489121003@sss.pgh.pa.us>
 <8371d0860a6019e5630bcdd2a96610ab.squirrel@sm.webmail.pair.com>
 <20170310135656.GD9812@tamriel.snowman.net> <12776.1489160501@sss.pgh.pa.us>
 <20170310162722.GG9812@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Fri, 10 Mar 2017 11:27:22 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14730.1489163780.1@sss.pgh.pa.us>
Date: Fri, 10 Mar 2017 11:36:20 -0500
Message-ID: <14731.1489163780@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> ... So I think the logging setup I had in
>> my patch is pretty much the only sane way to do it, and we just have
>> to decide whether it's worth exposing at default log level or not.

> I definitely think we should include it at the default log level.  We
> certainly wouldn't be the first daemon process to do so (bind9 comes to
> mind, but I notice ntpd, nrpe, and strongswan do also, and probably some
> others).

I'm leaning in that direction as well now.  I think we could address
Robert's concern about startup chattiness by downgrading the other
mentioned messages to DEBUG1.  I will check, but I'm pretty sure that
there is already adequate logging for subprocess startup failure ---
and if there is not, that would be a bug in itself.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers