Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAi4N-0008EY-Uj for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Nov 2016 18:51:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cAi4N-00059y-EI for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Nov 2016 18:51:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cAi4L-00059p-FM for pgsql-hackers@postgresql.org; Sat, 26 Nov 2016 18:51:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cAi4J-0006wg-11 for pgsql-hackers@postgresql.org; Sat, 26 Nov 2016 18:51:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id uAQIpHQC014733; Sat, 26 Nov 2016 13:51:18 -0500 From: Tom Lane To: Andreas Seltenreich cc: Oleg Bartunov , Teodor Sigaev , pgsql-hackers@postgresql.org Subject: Re: [sqlsmith] Failed assertion in TS_phrase_execute In-reply-to: <87eg1y2s3x.fsf@credativ.de> References: <87eg1y2s3x.fsf@credativ.de> Comments: In-reply-to Andreas Seltenreich message dated "Sat, 26 Nov 2016 16:11:46 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14731.1480186277.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 26 Nov 2016 13:51:17 -0500 Message-ID: <14732.1480186277@sss.pgh.pa.us> X-Pg-Spam-Score: -4.9 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andreas Seltenreich writes: > the query below triggers an assertion in TS_phrase_execute. Testing was > done on master at dbdfd11. > -- TRAP: FailedAssertion("!(curitem->qoperator.oper =3D=3D 4)", File: "ts= vector_op.c", Line: 1432) > select 'moscow' @@ > ts_rewrite('moscow', 'moscow', > ts_rewrite( > tsquery_phrase('moscow','moscow'), > 'moscow', > $$ 'sanct' & 'peter'$$)); Hmm. If you run the ts_rewrite alone, it prints regression=3D# select ts_rewrite('moscow', 'moscow', ts_rewrite( tsquery_phrase('moscow','moscow'), 'moscow', $$ 'sanct' & 'peter'$$)); ts_rewrite=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 ------------------------------------------------- ( 'sanct' & 'peter' ) <-> ( 'sanct' & 'peter' ) (1 row) and if you put that in explicitly, all's well: regression=3D# select 'moscow' @@ $$( 'sanct' & 'peter' ) <-> ( 'sanct' & '= peter' )$$::tsquery; ?column?=20 ---------- f (1 row) but I notice that some normalization seems to be getting done by tsqueryin: regression=3D# select $$( 'sanct' & 'peter' ) <-> ( 'sanct' & 'peter' )$$::= tsquery; tsquery=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 =20=20=20=20=20=20=20 ---------------------------------------------------------------------------= ----- ------- 'sanct' <-> 'sanct' & 'peter' <-> 'sanct' & 'sanct' <-> 'peter' & 'peter' = <-> ' peter' (1 row) so this seems to boil down to ts_rewrite failing to apply required normalization. Or maybe the normalization shouldn't be required. regards, tom lane --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers